Machine GUI crash - getBlockType() should be called in tile class - 2.5a

Question

Machine GUI crash - getBlockType() should be called in tile class - 2.5a

rjenkins2 opened this issue 7 years ago · 5 comments

rjenkins2 commented 7 years ago

I'm getting the following crash pretty consistently (but not always) when I open up the GUI for the manufactory.

https://pastebin.com/rQhXcJSZ

This might be a duplicate of #112, but their paste is no longer visible, so I can't tell for sure.

Version: 2.51-1.12.2
Forge: 2051
Modpack: Modern Skyblock 2 - v2.5.4

NielsPilgaard · Answer 1 · 2017-10-30T09:04:56.000Z

I'm getting this crash very frequently in SSP, even when in the JEI integration for the Manufactory.

https://pastebin.com/uVUgmTmu

tomdodd4598 · Answer 2 · 2017-12-05T01:59:50.000Z

I'm finally back - should be fixed now :)

tomdodd4598 · Answer 3 · 2017-10-08T20:25:34.000Z

Looks like the 'blockType' variable is nullPointering. Should be fixed by a simple null check.

rjenkins2 · Answer 4 · 2017-10-08T20:29:50.000Z

Looks like this is happening with all the GUIs in the mod. It seems to only happen on SMP, not in SSP. I can open and play with the machines in single player, no problem. But on my server, I get client crashes all the time with any NuclearCraft block when looking at the GUIs.

tomdodd4598 · Answer 5 · 2017-10-08T20:35:38.000Z

It's because I should be calling 'getBlockType()' instead of just using the 'blockType' variable. In SSP, it must get set to whatever the block is when placed, but in SMP, clearly that info is not sent to the client immediately. The first thing the 'getBlockType()' method does is checks if the variable is null, and if it is, sets it to the block the tile entity is connected to.

Share to