NuclearCraft

NuclearCraft

31M Downloads

[1.12+][Bug] Fission Reactor produces wrong amount of energy

OneEyeMaker opened this issue ยท 4 comments

commented

Hello.
The title says it all - Fission Reactor produces wrong amount of energy (and also wrong amount of heat!).
Example: HECf-251 Oxide produces amount that LECf-251 should produce.

I spend more then hour to find source of this bug. I'm still not 100% sure, but I guess it is there:

https://github.com/turbodiesel4598/NuclearCraft/blob/master/src/main/java/nc/recipe/generator/FissionRecipes.java#L44

There should be count += 4, because you register 1st and 2nd recipes first, then 3nd and 4th and in the next loop iteration you start again from 2nd and 3rd.
Maybe, there's bugs somewhere else (I didn't check).

Also, is it intended that configuration of fusion reactor is in code of fission one?
(https://github.com/turbodiesel4598/NuclearCraft/blob/master/src/main/java/nc/tile/generator/TileFissionController.java#L231)

commented

@turbodiesel4598
Any news about this issue?

commented

Yeh, should be a simple fix - will sort it out when I have the time :)

commented

Can confirm. Plopped a LEU-235-Ox into a reactor with 600% eff and 8 cells, and somehow producing 27648RF/T (should be 8064), and also far too much heat (surprise lava pool! ๐Ÿ˜ƒ ). I've made no adjustments to any of the default configs.

edit: I Did a bit more digging and it looks like there are a few exchanges of values in the calculations. So far I've found the following (I'll add more as I find them):

LEU - 235 gives LEU - 233 OX RF/t and heat
LEU - 235 OX gives HEU - 233 RF/t and heat
HEU - 235 gives HEU - 233 OX RF/t and heat
HEU - 235 OX gives LEU - 235 RF/t and heat

commented

Fixed by the above pull request :)