NuclearCraft

NuclearCraft

31M Downloads

[1.12.2] Crash on modifying tile entity

ToMe25 opened this issue · 17 comments

commented

The NuclearCraft version 2.18 crashes if you modify a tile entity(for example the Salt Mixer) by for example putting a Upgrade in or letting it finish a recipe.

Please use a paste tool such as Pastebin (https://pastebin.com) for crash logs!
https://pastebin.com/8VwbcqD3

commented
commented

I think I've fixed this, as it seems to no longer crash for me outside of the dev environment. Perhaps you could try this build before I upload to CF?

commented

Potentially related error (using any machine crashed): https://paste.dimdev.org/otegalohev.mccrash

The 2.18a build seems to have fixed it

commented

Great! I'll get it on CF now then :)

The issue was that these machines implemented an interface which was also called markDirty(), used in the code related to item handling. When trying to define this method in the main TE superclass, the Java compiler interpreted this as an override of only the base TE markDirty() method, ignoring the item-handling interface as that is only introduced in the subclasses used for the item-handling TEs. This meant that when the item-handling code looked for the implementation of the method, it couldn't find it, hence the 'abstract method' error. For some reason, the built-in Eclipse compiler on the other hand was able to deduce the correct method to refer to, so this slipped through testing :P

Anyways, it's sorted now. Thanks for the reports everyone!

commented

Can also confirm this fix works for me. Thanks for your quick turnaround!

commented

Would have been a bit snappier, but had extended family round from Canada today... played a cricket match and it took about as long to explain the rules as it took to play.

commented

Thank you! Works fine now.
And hey, family first man :)

commented

Can confirm, seems to be a issue with any of the UI's.
I have the same issue with the ManuFactory (https://pastebin.com/HzMjQpFP).
Simply clicking on the UI of it causes a insta-crash.

commented

i have tried a few more machines and they all crashed too.

commented

Same as well. Something definitely broke all the UI's, which really sucks because none of the machines are usable now. This is quite the serious bug.

commented

Strange, didn’t happen in testing. I’ll get a fix out pronto!

commented

In the meantime fellas, does this happen if only MC is installed?

commented

Confirmed here as well, albeit with 175 or so other mods.
https://pastebin.com/0DEdj827

commented

"does this happen if only MC is installed?" i mean i tested it with only nc and ccl so i guess it does.
i can test it again without ccl later if you want me to do that, but i always test crashes with the least other mods* i can before reporting.

*besides ccl because removing that sometimes causes trouble for me and most mods need it anyways

commented

Oh, turns out it also crashes the server if another mod accesses the inventories, so it's not just the UI...

commented

yeh its the tile entity itself.