NuclearCraft

NuclearCraft

31M Downloads

NuclearCraft registers tons of invalid OreDictionary entries

OneEyeMaker opened this issue ยท 2 comments

commented

The title says it all. Mod registers tons of empty OreDictionary entries. (Empty entry = entry with name but without any associated ItemStacks).
Most of these entries are modified names of fluids (!!!). For example: ingotBiodiesel, gemBio.ethanol and so on.

I guess, one of the causes of this bug is usage of method OreDictionary.getOres(String). This method creates empty entry if fails to find existing one.
Instead you should use OreDictionary.getOres(String, boolean) (with second argument = false) in most cases.

P. S. Please, fix this issue before overhaul.

commented

Ah, I did not realise - fixed!