NuclearCraft

NuclearCraft

34M Downloads

plutonium spawning in overworld

ShawnRHayes opened this issue ยท 12 comments

commented

for some reason I am getting it in overworld generation , tested with only NEI, CCC, forge 1558 version 1.6a

commented

That is very strange - I've checked the ore gen. class again, and it really shouldn't be - is there netherrack around it when it spawns?

commented

it is a nether type ore , here is a screenshot https://gyazo.com/bf63b6d183f3fa528e309a8bc9d2412e

commented

Very, very strange - if you go to the WorldGen class, you can see that plutonium should only be spawning in the Nether. I'm not sure what I can do about this, unless I made a mistake somewhere.

commented

maybe it needs to be a separate block id , I am just guessing , I never modded MC

commented

Possibly, but the individual ore blocks are defined and registered separately, so that shouldn't be a problem.

commented

hope it gets figured out, it looks like an awesome mod and I would love to have it spawn as intended so i could put it in a legit world!

commented

Well, plutonium ore is definitely not a requirement - it can be bred through fission reactions - you can just go into the ore config file and disable its generation ;)

commented

Actually, it is a bigger problem than that. Plutonium is spawning in place of uranium.

And I found out why:
From OreGen class:
pitchblende = new WorldGenMinable(NRBlocks.blockOre, NuclearRelativistics.oreSizePitchblende, 6, Blocks.stone);

annnnd:
plutonium = new WorldGenMinable(NRBlocks.blockOre, 6, NuclearRelativistics.oreSizePlutonium, Blocks.netherrack)

Simple duplication, easy mistake to make and miss.

commented

Facepalm great spot - thanks a bunch - will release a fix as soon as possible (i.e. in 12 hours or so).

commented

Yup, it is nice when I can both spot a bug AND find the fix all at once. And that is the kind of bug where you look at your code and just not notice it again, and again, and again and then, yeah, facepalm. I've done that way too often. Hell, I had to read the code in question twice before I got it.

commented

Just released a fix - version 1.6b ;)

I guess I'll close this when it can be confirmed that ores are spawning as intended again.

commented

thanks 1skandar for finding the code issue and Turbodiesel for resolving this !