Numismatic Overhaul

When using numismatic with modernui the coin icon partially covers the number,

Unfortunately I don't think this issue is a great concern for us, given that ModernUI explicitly causes it - please report it to them instead. This is also more likely to lead to a solution, as they will be much more familiar with the modifications they make to text rendering code, whereas we would need to first reverse-engineer their implementation

I'll leave this issue open for now until we hear from them, but we won't be actively looking into it

Cheers

This is a common problem, your code assumes incorrect text layout:

numismatic-overhaul/src/main/java/com/glisco/numismaticoverhaul/client/gui/CurrencyTooltipRenderer.java

Lines 53 to 56 in a5b5078

    
           private static Text createPlaceholder(String text) { 
        
               String placeholder = "§7   " + text + " "; 
        
               return Text.of(placeholder); 
        
           }

Modern UI has a Complex Text Layout Engine, the width of space characters depends on FreeType scaler and TrueType designer, and it's context-aware. Thus, you may write a helper method kinda like this, if you want to provide reliable indentation:

// in yarn namespace
static String indentation(TextRenderer tr, int indent) {
    var str = " ";
    while (tr.getWidth(str) < indent) str += " ";
    return str;
}

Notably, you shouldn't measure a single space character and do division. Firstly, getWidth returns the ceiling of string width. Secondly, text layout is context-aware, it's not linear.
But you can cache this indentation string after a resource reload on main thread, to deal with font changes, via net.fabricmc.fabric.api.resource.SimpleResourceReloadListener#apply

Fixed as of 0.2.12 for 1.20.1 and 1.20.2

	private static Text createPlaceholder(String text) {
	String placeholder = "§7 " + text + " ";
	return Text.of(placeholder);
	}

Share to