[Urgent] Duplicate any item easily with shop block
UnnamedWei opened this issue · 8 comments
Step 1:Owner puts something in the shop
Step 2:Another player opens the shop screen but dont close it
Step3:The Owner takes item out
Step4:Another player buys it and there you have two of that item now
This happened on my server and I have to temporarily ban all player shops, waiting for a fix, thank you very much
Suggestion:
- Could you make it that when someone is trading the owner can’t open it or destroy it something to fix this?
- Can you make the creative mode shop (infinite shop block) indestructible (make it like bedrock)?
- Thanks a lot
For feature suggestions please open new issues, as tracking them inside an important bug report like this is not ideal.
As for your two suggestions: the first has been implemented as part of the fix as of 0e62c8a. It is scheduled for the next release.
The second suggestion is not something we are interested in implementing. Frankly, having shop blocks act as Bedrock, a completely unbreakable block, will lead to abuse where it is treated as such. Claim mods and protection mods already solve this issue.
Will the new release with the fix possibly clear or disable previous trades in the shop block that already exist in a server/world? Thanks
Not sure exactly what you mean by this. Do you mean removing the inventories of shop blocks? No. This is not something we would do, as it doesn't make a ton of sense, as well as leading to confusion among why items suddenly disappeared from shops.
There is nothing wrong with the trades themselves, but the logic of performing the trade, which has now been fixed.
When will the next update be? Will there be new content added beside this fix? We really love this mod and are looking forward to it. Thanks.
Unfortunately it is a bit hard to say when exactly we have the possibility to make a release, due to being in the middle of the holiday season. Generally it will be released as soon as possible