Observable

Observable

6M Downloads

[Forge] Overlay and results in overworld brings me to 0fps

aaronhowser1 opened this issue ยท 10 comments

commented

image
The above is with 32 render distance, below is 16:
image

16 with overlay disabled:
image

image
Here's after opening the results. It might be lagging because there's so many things? Idk.

It crashed within a couple seconds, here's that crash report: https://pastebin.com/cpyDGL1i

commented

The results would also lead you to believe that it's lagging massively, but it's at 20 tps.

commented

The crash (I suspect) is happening for the same reason as #5, which will be fixed momentarily. As for the performance, I suspect that's being caused by the text renderer having to query a couple hundred thousand items to see if they're in range, so my two options are either some kind of spatial hashing or just refusing to render text in the world. (Either that or somehow cache text VBOs, but I haven't been able to find any resources on that.) Which option sounds best for you?

commented

Can it limit it to like the 1000 nearest ones or something? And only refresh every 10 seconds. Both should be configurable for best UX.

If it were just rendering text in the world (I assume you mean the text on the block) why would it be lagging in the last picture that has Overlay disabled but has the Results menu open?

commented

Can it limit it to like the 1000 nearest ones or something?

Text (for block timings) is limited to a 128 block radius when it comes to rendering. The issue comes in when the game has to loop through all elements to find the ones that satisfy that condition.

why would it be lagging in the last picture that has Overlay disabled but has the Results menu open?

That's because the results menu is also looping over every element. I'm going to add pagination after I fix the crashing issue, give me about a half hour total.

commented

The UI text issue is fixed in master

commented

Is this issue still happening for you, or can I close this?

commented

I haven't tested it, I'll try the newest update now

commented

image
Big improvement on fps!

It crashed immediately after taking that screenshot: https://pastebin.com/eyp6M1dG

commented

Crash should be fixed in the latest version

commented

Awesome, no crashes from ten minutes of mucking around with it. FPS issues are also entirely gone.