Occultism

Occultism

19M Downloads

[1.21] [Neoforge] Bound items Text unredable

ffuentesm opened this issue ยท 14 comments

commented

Describe the bug
Bound items have the entire text scrambled instead of just the orange text

To Reproduce
Steps to reproduce the behavior:

  1. hover over a bound item

Expected behavior
Only a section of the text should be scrambled

Screenshots

Recording.2024-06-22.215859.mp4

System (please complete the following information):
Occultism Version: 1.133.2
OS: Windows
Minecraft Version: 1.21

commented

I am not sure I understand (the video is not playing properly for me, so maybe that is why).
To me it looks like the white text is not scrambling?

I can look into it, but this is all vanilla text effects so I would be surprised if they changed how they work. How does it behave on e.g. 1.20.1?

commented

in 1.20.1 there is actually no scrambling of the words. All the text is static.

1.20.1.recording.behaviour.mp4
commented

@ffuentesm I am wondering, do you have any other mods in the setup?
For me it doesn't do that at all, neither in SP nor in MP. I can try to add something that might help but without reproducing the cause it's a bit of a blind flight :D

commented

the next commit will auto-close this issue, please ping me to reopen if the released version does not fix it!

commented

Ok that makes more sense actually, I thought I was going crazy!
I think I know what is going on, the change from nbt -> data components apparently causes jei to re-roll the name on each tick. I have to look into how to get around that

commented

@klikli-dev Yep, I am currently with a few mods in 1.21. I can try to see this without them.
Your 1.133.3 update, fixed most of the problem.
Now the only items with the Scrambled text are the 4 mining lamps.

commented

@klikli-dev the problem persists on the miners even when I have no other mods installed.
Also, Neoforge 21.0.31 has a new crash on launch
image

commented

@klikli-dev the problem persists on the miners even when I have no other mods installed. Also, Neoforge 21.0.31 has a new crash on launch image

@ffuentesm that crash is due to a breaking change in Neo, the update from 5 minutes ago updates past the breaking changes

commented

@klikli-dev the problem persists on the miners even when I have no other mods installed. Also, Neoforge 21.0.31 has a new crash on launch image

@ffuentesm as for the miners, I will quickly test in a live environment if I can make it happen there.
I think the issue may be the jei version, maybe a newer version causes it and my old one does not or something like that

commented

From what I am seeing in your commits
You did not add the miners to the Prejenerated Spirit name list unless they are the dimensional_matrix.
image

commented

Ahh that must be it. Turned off my brain there for a moment it seems. Let me take a look!

commented

Ok that should do it! The lamps still didn't reproduce the problem for me, but they are now on the list :)

commented

Thanks, they are now Fixed.

commented

Issue exists on EMI still despite being fixed on JEI