Demon's dream huge fps lag with unstable otherworld tree
uiytt opened this issue · 6 comments
Describe the bug
When you eat Demon's Fruit next to a lot of unstable otherworld tree (~15), you lost around 200 fps
To Reproduce
Steps to reproduce the behavior:
- Grow around 15 unstable otherworld tree next to each others
- Eat demon's fruit
- Lose 200 fps
- OTHERWORLD GOGGLES works fine
Expected behavior
Almost no lag like Otherworld goggles.
System (please complete the following information):
- Occultism Version: 1.11.3
- OS: Ubuntu (linux)
- Minecraft Version: 1.16.5
- Modpack Link and Version, or list of mods: Curios API (1.16.5-4.0.5.3) & Patchouli (1.16.4-53.1)
Additional context
Discovered this problem in otherworld groves
@uiytt thank's for testing. There is only one remaining difference between goggles and the dream, and that is that dream is trying to unload the shader, even if it was not loaded.
That should not cause an issue, but maybe there's no proper state management, so I'm going to make the setting affect that too in #407. If the issue still persists after that .. well not sure what to do then, we'll have to brainstorm a bit then 🤷
@uiytt thank's for testing. There is only one remaining difference between goggles and the dream, and that is that dream is trying to unload the shader, even if it was not loaded.
That should not cause an issue, but maybe there's no proper state management, so I'm going to make the setting affect that too in #407. If the issue still persists after that .. well not sure what to do then, we'll have to brainstorm a bit then shrug
Where you able to reproduce the problem ?
I might also look at the code, I'm not very good with Forge but I have a basic level in Java so 🤷♂️
Issue is not fixed in 1.11.4 :c
Thanks for letting me know - I'll experiment a bit to see if I can reproduce it on my end, and see if I can further unify the codebase between the dream and the goggles
@uiytt turns out the dream code was fine, but the goggles code was partially active in parallel (due to some edge-case handling that should cleanly handle switching/parallel goggles and dream). After some refactoring it no longer reproduces on my end :)
Goggles and demon's dream actually work the same way internally, except that the fruit is using a shader.
Can you try to set disableDemonsDreamShaders
to true
in the client config occultism-client.toml and let me know if the issues persist?
[visual]
#Disables the headache- and possibly seizure-inducing visual effects of Demon's Dream.
disableDemonsDreamShaders = true
Goggles and demon's dream actually work the same way internally, except that the fruit is using a shader.
Can you try to set
disableDemonsDreamShaders
totrue
in the client config occultism-client.toml and let me know if the issues persist?[visual] #Disables the headache- and possibly seizure-inducing visual effects of Demon's Dream. disableDemonsDreamShaders = true
Unfortunately, the shader is indeed disabled, but I still get huge lag.
(Third eye combined with the goggles doesn't do any lag)