Oculus

Oculus

60M Downloads

Not Enough Crashes popup unnecessary on 1.18.2

MattB70 opened this issue ยท 7 comments

commented

What happened?

Oculus for 1.18.2 shows a popup complaining about Not Enough Crashes and recommends two alternatives (MixinTrace and Crafty Crashes). Both alternatives are not available on Forge 1.18.2.

Screenshots

No response

Relevant log output

No response

Minecraft Version

1.18.2

Oculus Version

oculus-1.4.3

Rubidium Version

rubidium-0.5.4

Operating System

Windows 11

What is your GPU?

RTX 2080

Java Version

JDK 17

Additional context

Unless the stated alternatives are coming to Forge 1.18.2, I'd just remove the popup, If Not Enough Crashes being present voids the relevance of issues posted here, then you can simply state that in the issue template here. For my own purposes, I have the game close after Not Enough Crashes does it's thing anyways, and I use it mainly for the easier formatting of the report for users to send to me, so I'm safe, but I do understand the reasoning behind not wanting to support it. Issues occurring after it's "recovery" are probably not repeatable in a normal game state.

Anyways, thanks for the quick updates btw, keep it up. :)

commented

same with 1.16.5

commented

oh, thank you, i didn't quite understand the bug description, sorry for the inconvenience.

commented

I'm not a developer, nor related in any way to this mod, but i believe this isn't a bug and actually a recommendation that's put there by design, since not enough crashes isn't actually that good at identifying the purpose of crashes.

commented

@NoFoxHr A bug doesn't have to be a glitch, error, crash, or otherwise related to code. In this case "bug" refers to a mistake in logic as Forge 1.18.2 does not support the listed alternatives.

Aside: After skimming the NotEnoughCrashes repo I can also support the motion of not supporting it outright. It does very little good, and is often a cause of crashing. The issue is still relevant though as listed alternatives should either exist or not be mentioned.

commented

It also pops up on iris but crafty crashes is only for 1.14 (on curse) and fabric, and mixin trace is also only fabric. I'm guessing its from porting iris from fabric and it not being checked as its kinda rare/not a priority as it doesn't break (at least from testing with iris).
It should be fine to remove that part but keep the NEC part if it does actually break something, and if there are any working forge mixin tracers then add them (im not experienced with forge but i found Mixin Conflict Helper and potentially Cyanide)

commented

mods suggested on popup can be change with this mod: https://www.curseforge.com/minecraft/mc-mods/craftitrace