Incompatibility With Figura Mod on Forge
SkightMeow opened this issue · 6 comments
Minecraft Version
1.20.1
Oculus Version
oculus-mc1.20.1-1.6.15
Rubidium / Embeddium Version
embeddium-0.3.1+mc1.20.1
Operating System
win 11
What is your GPU?
rtx 3070
Java Version
jdk 17
Reproduction Steps
launch game with both mods
Crash Report file and latest.log
Exception caught from launcher
java.lang.reflect.InvocationTargetException
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:568)
at io.github.zekerzhayard.forgewrapper.installer.Main.main(Main.java:67)
at org.prismlauncher.launcher.impl.StandardLauncher.launch(StandardLauncher.java:87)
at org.prismlauncher.EntryPoint.listen(EntryPoint.java:130)
at org.prismlauncher.EntryPoint.main(EntryPoint.java:70)
Caused by: java.lang.RuntimeException: java.lang.reflect.InvocationTargetException
at MC-BOOTSTRAP/[email protected]/cpw.mods.modlauncher.LaunchServiceHandlerDecorator.launch(LaunchServiceHandlerDecorator.java:32)
at MC-BOOTSTRAP/[email protected]/cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:53)
at MC-BOOTSTRAP/[email protected]/cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:71)
at MC-BOOTSTRAP/[email protected]/cpw.mods.modlauncher.Launcher.run(Launcher.java:108)
at MC-BOOTSTRAP/[email protected]/cpw.mods.modlauncher.Launcher.main(Launcher.java:78)
at MC-BOOTSTRAP/[email protected]/cpw.mods.modlauncher.BootstrapLaunchConsumer.accept(BootstrapLaunchConsumer.java:26)
at MC-BOOTSTRAP/[email protected]/cpw.mods.modlauncher.BootstrapLaunchConsumer.accept(BootstrapLaunchConsumer.java:23)
at [email protected]/cpw.mods.bootstraplauncher.BootstrapLauncher.main(BootstrapLauncher.java:141)
... 8 more
Caused by: java.lang.reflect.InvocationTargetException
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:568)
at MC-BOOTSTRAP/[email protected]/net.minecraftforge.fml.loading.targets.CommonLaunchHandler.runTarget(CommonLaunchHandler.java:111)
at MC-BOOTSTRAP/[email protected]/net.minecraftforge.fml.loading.targets.CommonLaunchHandler.clientService(CommonLaunchHandler.java:99)
at MC-BOOTSTRAP/[email protected]/net.minecraftforge.fml.loading.targets.CommonClientLaunchHandler.lambda$makeService$0(CommonClientLaunchHandler.java:25)
at MC-BOOTSTRAP/[email protected]/cpw.mods.modlauncher.LaunchServiceHandlerDecorator.launch(LaunchServiceHandlerDecorator.java:30)
... 15 more
Caused by: java.lang.ExceptionInInitializerError
at TRANSFORMER/[email protected]/net.minecraft.resources.ResourceKey.m_135788_(ResourceKey.java:26)
at TRANSFORMER/[email protected]/net.minecraft.core.registries.Registries.m_257397_(Registries.java:200)
at TRANSFORMER/[email protected]/net.minecraft.core.registries.Registries.<clinit>(Registries.java:93)
at TRANSFORMER/[email protected]/net.minecraft.world.flag.FeatureElement.<clinit>(FeatureElement.java:18)
at TRANSFORMER/[email protected]/net.minecraft.world.level.block.Blocks.<clinit>(Blocks.java:45)
at TRANSFORMER/[email protected]/net.minecraft.world.item.Items.<clinit>(Items.java:21)
at TRANSFORMER/[email protected]/net.minecraft.client.renderer.entity.ItemRenderer.<clinit>(ItemRenderer.java:51)
at TRANSFORMER/[email protected]/net.minecraft.client.renderer.RenderType.<clinit>(RenderType.java:101)
at TRANSFORMER/[email protected]+1.20.1/forge.org.figuramc.figura.model.rendering.texture.RenderTypes.<clinit>(RenderTypes.java:27)
at TRANSFORMER/[email protected]+1.20.1/forge.org.figuramc.figura.lua.docs.FiguraListDocs$2.<init>(FiguraListDocs.java:44)
at TRANSFORMER/[email protected]+1.20.1/forge.org.figuramc.figura.lua.docs.FiguraListDocs.<clinit>(FiguraListDocs.java:43)
at TRANSFORMER/[email protected]/com.mojang.blaze3d.platform.InputConstants$Type.handler$gok000$addKey(InputConstants.java:515)
at TRANSFORMER/[email protected]/com.mojang.blaze3d.platform.InputConstants$Type.m_84899_(InputConstants.java)
at TRANSFORMER/[email protected]/com.mojang.blaze3d.platform.InputConstants$Type.<clinit>(InputConstants.java:214)
at TRANSFORMER/[email protected]/net.coderbot.iris.Iris.<clinit>(Iris.java:95)
at TRANSFORMER/[email protected]/net.minecraft.SystemReport.handler$bhm000$fillSystemDetails(SystemReport.java:523)
at TRANSFORMER/[email protected]/net.minecraft.SystemReport.<init>(SystemReport.java:58)
at TRANSFORMER/[email protected]/net.minecraft.CrashReport.<init>(CrashReport.java:31)
at TRANSFORMER/[email protected]/net.minecraft.CrashReport.m_127529_(CrashReport.java:216)
at TRANSFORMER/[email protected]/net.minecraft.client.main.Main.main(Main.java:149)
... 23 more
Caused by: java.lang.IllegalArgumentException: Not bootstrapped (called from registry ResourceKey[minecraft:root / minecraft:root])
at TRANSFORMER/[email protected]/net.minecraft.server.Bootstrap.m_179916_(Bootstrap.java:113)
at TRANSFORMER/[email protected]/net.minecraft.server.Bootstrap.m_179912_(Bootstrap.java:106)
at TRANSFORMER/[email protected]/net.minecraft.core.MappedRegistry.<init>(MappedRegistry.java:85)
at TRANSFORMER/[email protected]/net.minecraft.core.MappedRegistry.<init>(MappedRegistry.java:81)
at TRANSFORMER/[email protected]/net.minecraft.core.registries.BuiltInRegistries.<clinit>(BuiltInRegistries.java:113)
... 43 moreAdditional context
issue reported on Figura github here
Hi one of the developers of the Figura mod here, our mod has always worked fine with Iris on Fabric and we don't actually have any platform specific code that should be causing it to crash, could we know why the issue was closed as invalid and not planned if this is an Oculus issue? We've had several users report this problem and apparently older Oculus releases worked fine so this is relatively new.
And fyi, you introduced this issue on your own two weeks ago with your merge, please be more careful is possible in the future, Oculus is an important mod for some people.
https://github.com/Asek3/Oculus/blame/22f576e6b077231507ac8ad4765421f39c777fa4/src/main/java/net/coderbot/iris/Iris.java#L95
I'd like it if the keybind's creation matched upstream's behavior, you guys are creating your keybinds on class load which is too early, it could cause issues for mods other than us as well, because it's not safe to do so yet, upstream Iris, (and Oculus previously matched this) create their keybinds on the onEarlyInitialize method. If the initialization is moved back to onEarlyInitialize it should fix the problem. I'm not asking for much here, it really is a trivial fix.