Question about player models and HD skins
C0rn3j opened this issue ยท 11 comments
Hiya, how does this mod know whether to use the Alex or Steve skin? Is it implemented even?
Also one more thing - would you consider implementing rendering of higher res skins? Since custom servers are now allowed it'd be an interesting addition.
I'm talking about skins like this, the only mod allowing this I found is for 1.7.10 or earlier.
One more thing - If I wanted to PM/IM you, where could I reach you? ^^
Currently, the mod checks a specific pixel to see if it is transparent or not to determine which model to use.
Smart! Could you add this somewhere? Perhaps as a config comment? ^^
Also I'm not sure if this is totally compatible with most skins? Perhaps querying a text file first would be a better idea and you could use the current method as a fallback if it doesn't exist? e.g. /skins/C0rn3j.txt
which would have 1 or 0, or Axel or Steve or whatever.
they don't really fit into normal minecraft theme
In the vanilla with no resource pack/shaders perhaps, but if you add any of these, it's the characters that may start to look unfitting. I think it really depends on the players.
and they require extra codes to implement.(Also custom skin servers) That's why i did't implement them before.
About custom skin servers, yeah, I imagine this is not going to be the most used feature (or maybe it will, what do I know, people may suddenly take interest now that a feature like this will be available).
Would you consider implementing this anyways? ^^
If this can be done I wouldn't mind throwing a few $ your way(granted we can figure a way out to do that since you live in China), it seems like a cool feature to have.
Currently, the mod checks a specific pixel to see if it is transparent or not to determine which model to use.
if (((image.getRGB(55, 20) & 0xFF000000) >>> 24) == 0) return "slim"; else return "default";
About hires skins, they don't really fit into normal minecraft theme and they require extra codes to implement.(Also custom skin servers) That's why i did't implement them before.
If you want to PM me, you can PM me on curseforge. I will try to check them regularly.
That is awesome! Does it work for capes too? Are there any limitations?
Also do you use BTC/ZEC/Paypal?
It should work with capes.
You can't use smaller resolution and odd numbers might cause problems.
Image's height needs to be half of it's width or equal to it's width.
If you want to use slim model, you will need to use the new format Mojang introduced. (height equals to width)
It will work best if the provided image's width is divisible by 64.
Currently i don't use them. And i don't want to accept any money.
If i change my mind later, i will put a donation link in the curseforge project page.
Some questions about the model.
Skin type influences the model used for player, default
skin can also use slim
type.
https://github.com/zlainsama/OfflineSkins/blob/master/src/main/java/lain/mods/skins/SkinData.java#L67-L68
In this code, default
has its special model, is it correct?
@xfl03
No.
"default" means a model like steve.
"slim" means a model like alex.
"legacy" is just a tag i used for pre-1.8 skin files, but it doesn't do anything because they are converted to newer format anyways.
@xfl03
They are "default" after conversion.
https://github.com/zlainsama/OfflineSkins/blob/master/src/main/java/lain/mods/skins/providers/MojangCachedSkinProvider.java#L68-L77
@zlainsama
It is true that legacy skin uses default
model.
In vanilla minecraft, only default
or slim
is used as the model name.
Other mods may not recognize it if you use a different model name.
If it is not an alex skin, use default
rather than legacy
may be better.