OfflineSkins

OfflineSkins

528k Downloads

Leg covers doesn't appear anymore in v3a

vico93 opened this issue · 10 comments

commented

Hi!

When i load MC with your mod installed and using this skin:

The pants of the skin (legs covers) arent rendered, so i end up with awkwardly without pants 😝

Without your mod:

...and with your mod:

Can you fix this?

commented

It worked fine on my side.
Could you check your Skin Customization settings in Options menu?

commented

2017-11-10_00 41 53

commented

For further information, here is my modlist according to ModDetectorApi:
https://gist.github.com/vpontin/4c6357a0e21f5c0f46de20e8f5d9b58d

The Raw class files are CustomStuff3 mods which only add blocks into game.

And here my latest log: https://gist.github.com/vpontin/6be18a7b9e28d8f1d45b0103e959944a

commented

Could you try with OfflineSkins only? and try downgrading Optifine to a public stable release? to see if this still occurs.

commented

@zlainsama , sorry for making you wait for an eternity, but yes, OfflineSkins doesnt load legs covers even alone:

Zero mods:
2018-05-16_19 30 03

OfflineSkins:
2018-05-16_19 31 30

Confirmed with Forge b2691 without Optifine or any mods.

commented

It is a bug of OfflineSkins.

These two lines removed your leg covers:
https://github.com/zlainsama/OfflineSkins/blob/master/src/main/java/lain/mods/skins/LegacyConversion.java#L50
https://github.com/zlainsama/OfflineSkins/blob/master/src/main/java/lain/mods/skins/LegacyConversion.java#L54

It is highly recommended to implement the skin coverter like CustomSkinLoader:
I changed the way to judge if the area needs to be removed.
https://github.com/xfl03/MCCustomSkinLoader/blob/csl-14/Common/source/customskinloader/fake/FakeSkinBuffer.java#L68-L77

Or change the code into these like vanilla(may cause more bug):

        setAreaOpaque(0 * r, 0 * r, 32 * r, 16 * r);
        setAreaTransparent(32 * r, 0 * r, 64 * r, 32 * r);
        setAreaOpaque(0 * r, 16 * r, 64 * r, 32 * r);
        setAreaOpaque(16 * r, 48 * r, 48 * r, 64 * r);

Chinese Edition for author:
这张皮肤的外层腿部没有透明像素,导致直接被移除。
建议更换成CustomSkinLoader那样的检测方式。

commented

Interesting. Thanks for your report.
I kinda didnt understand your mod description, so i'll stick with offlineskins. But anyway thanks for your comment.

commented

It is not an AD for CustomSkinLoader.
I just provided the way to solve the problem you have to the author :)

commented

A new version will be (1.12.2-v4) is released to fix this problem.
Thanks to @xfl03 , you pointed out where the problem was.

commented

Thanks a lot @xfl03 and @zlainsama for the fix!!!