Oh The Biomes You'll Go Refabricated

Oh The Biomes You'll Go Refabricated

12M Downloads

[1.19][Bug]: byg:tall_allium and byg:tall_pink_allium are tagged as minecraft:small_flowers

TelepathicGrunt opened this issue ยท 3 comments

commented

BYG Version

2.0.0.13

Terrablender Version

N/A

Mod Loader

Forge

Mod Loader Version

N/A

Bug Severity

Minor

What happened?

byg:tall_allium and byg:tall_pink_allium are tagged as minecraft:small_flowers when they are double block tall plants. As a result, my mod and probably a few others may be spawning half of this tall plant by mistake.

The tag to edit in BYG:
https://github.com/AOCAWOL/BYG/blob/c8183683fbb0f641e0e79675431557d384a4f456/Common/src/main/resources/data/minecraft/tags/blocks/small_flowers.json#L61-L62

image

latest.log

no log

Did you isolate BYG?

I tried BYG alone

commented

Also, Pollen Block is put here as well. Which is going to cause some weird behaviors with mods checking for small flower tagged blocks. Like My pollen puff block tries to multiply flower tagged blocks as if it is pollinating flowers. I can try to blacklist this block from my behaviors but I can't say how other mods may react with this pollen block
https://github.com/AOCAWOL/BYG/blob/c8183683fbb0f641e0e79675431557d384a4f456/Common/src/main/resources/data/minecraft/tags/blocks/small_flowers.json#L60

commented

byg:delphinium and byg:japanese_orchid appears to also be a double tall flower tagged as a small flower. Might be a good idea to go through this tag entirely to make sure it is small flowers and not double tall flowers
https://github.com/AOCAWOL/BYG/blob/c8183683fbb0f641e0e79675431557d384a4f456/Common/src/main/resources/data/minecraft/tags/blocks/small_flowers.json#L19

commented

Fixed in: 60aaa34