Removing mods that add some things (such as villager types) causes BYG to crash due to invalid config

Question

Removing mods that add some things (such as villager types) causes BYG to crash due to invalid config

ChiefArug opened this issue 2 years ago · 0 comments

ChiefArug commented 2 years ago

BYG Version

N/A

Terrablender Version

N/A

Mod Loader

Forge

Mod Loader Version

N/A

Bug Severity

Major

What happened?

BYG generates its config on first launch, and uses things other mods register in that.
When you remove those mods BYG gets annoyed because the values are in its config but no longer present in game.

While generating the config based on installed mods is a great feature, its terrible for usability. (having to delete your config most of the time you add or remove mods is not fun)

Could this be changed so that removing a mod no longer causes crashes.
Something like having a 'generated' config folder that gets genned every launch (or when the mod list changes), but is only used if the non generated config is empty (so if someone wants to use a custom config they just need to copy the files out of generated and modify them).

latest.log

The sort of error found in the crash report (if you want a full one see #1021, #974, #871 and I'm sure there are others)

A detailed walkthrough of the error, its code path and all known details is as follows:
---------------------------------------------------------------------------------------

-- Head --
Thread: Render thread
Stacktrace:
	at potionstudios.byg.BYG.commonLoad(BYG.java:70) ~[Oh_The_Biomes_You'll_Go-forge-1.18.2-1.4.7.jar%23293!/:1.4.7] {re:mixin,re:classloading,pl:rei_plugin_compatibilities:B}
-- MOD byg --
Details:
	Mod File: /C:/curseforge/minecraft/Instances/Modpack/mods/Oh_The_Biomes_You'll_Go-forge-1.18.2-1.4.7.jar
	Failure message: Oh The Biomes You'll Go (byg) encountered an error during the common_setup event phase
		java.lang.IllegalStateException: Config errors were found:
		
		java.lang.IllegalArgumentException: Jankson file reading for "C:\curseforge\minecraft\Instances\Modpack\config\byg\trades.json5" failed due to the following error(s):
		java.lang.IllegalArgumentException: Jankson file reading for "C:\curseforge\minecraft\Instances\Modpack\config\byg\trades.json5" failed due to the following error(s):
		"productivebees:beekeeper" is not a valid id in registry: Registry[ResourceKey[minecraft:root / minecraft:villager_profession] (Experimental)].

Did you isolate BYG?

I did not try BYG alone

Share to