Oh The Biomes You'll Go Refabricated

Oh The Biomes You'll Go Refabricated

Mods
11M Downloads

[1.19][Bug]: Trading Lists of Some Villager are reversed

Viola-Siemens opened this issue ยท 0 comments

commented

BYG Version

2.0.0.13

Terrablender Version

2.0.1.128

Mod Loader

Forge

Mod Loader Version

43.2.0

Bug Severity

Minor

What happened?

I'm not one hundred percent sure what you want to do, but it must be something wrong with the trading list of some villagers.
For example, are these two trades reversed? (the first two images are trades visualized by JEI and Emerald Craft, and the third one and last one are what it actually be in the game)
https://ibb.co/L5ctDkM
https://ibb.co/yYYHQJW
https://ibb.co/hcW84Yy
https://ibb.co/89JWb6Q

I think this is the way to solve:
https://github.com/AOCAWOL/BYG/blob/1.19.X/Common/src/main/java/potionstudios/byg/common/entity/npc/BYGVillagerTrades.java#L83
you can change:

3, new VillagerTrades.ItemListing[]{
    new VillagerTrades.ItemsForEmeralds(BYGItems.ROCKY_STONE.get(), 1, 12, 12, 2),
    new VillagerTrades.EmeraldForItems(BYGItems.ROCKY_STONE.get(), 1, 12, 12),
    new VillagerTrades.ItemsForEmeralds(BYGItems.MOSSY_STONE.get(), 1, 12, 12, 2),
    new VillagerTrades.EmeraldForItems(BYGItems.MOSSY_STONE.get(), 1, 12, 12)
},
4, new VillagerTrades.ItemListing[]{
    new VillagerTrades.ItemsForEmeralds(BYGItems.DACITE.get(), 1, 12, 12, 2),
    new VillagerTrades.EmeraldForItems(BYGItems.DACITE.get(), 1, 12, 12),
    new VillagerTrades.ItemsForEmeralds(BYGItems.SOAPSTONE.get(), 1, 12, 12, 2),
    new VillagerTrades.EmeraldForItems(BYGItems.SOAPSTONE.get(), 1, 12, 12),
    new VillagerTrades.ItemsForEmeralds(BYGItems.RED_ROCK.get(), 1, 12, 12, 2),
    new VillagerTrades.EmeraldForItems(BYGItems.RED_ROCK.get(), 1, 12, 12)
}

into:

3, new VillagerTrades.ItemListing[]{
    new VillagerTrades.EmeraldForItems(BYGItems.ROCKY_STONE.get(), 12, 12, 20),
    new VillagerTrades.ItemsForEmeralds(BYGItems.ROCKY_STONE.get(), 1, 1, 12, 10),
    new VillagerTrades.EmeraldForItems(BYGItems.MOSSY_STONE.get(), 12, 12, 20),
    new VillagerTrades.ItemsForEmeralds(BYGItems.MOSSY_STONE.get(), 1, 1, 12, 10)
},
4, new VillagerTrades.ItemListing[]{
    new VillagerTrades.EmeraldForItems(BYGItems.DACITE.get(), 12, 12, 30),
    new VillagerTrades.ItemsForEmeralds(BYGItems.DACITE.get(), 1, 1, 12, 15),
    new VillagerTrades.EmeraldForItems(BYGItems.SOAPSTONE.get(), 12, 12, 30),
    new VillagerTrades.ItemsForEmeralds(BYGItems.SOAPSTONE.get(), 1, 1, 12, 15),
    new VillagerTrades.EmeraldForItems(BYGItems.RED_ROCK.get(), 12, 12, 30),
    new VillagerTrades.ItemsForEmeralds(BYGItems.RED_ROCK.get(), 1, 1, 12, 15)
}

latest.log

N/A

Did you isolate BYG?

I tried BYG alone