Oh The Biomes You'll Go Refabricated

Oh The Biomes You'll Go Refabricated

11M Downloads

[1.16.3] Dedicated server hard lock on player logging in. w/ MCP: VoxelShapeSpliterator.func_234878_a_() Yarn: BlockCollisionSpliterator.offerBlockShape Mojmap: CollisionSpliterator.collisionCheck

ProsperCraft opened this issue ยท 17 comments

commented

image

forge-1.16.3-34.1.23
byg-1.0.8
Modpack - TownCraft TWO

This is a shot in the dark, I am hoping you recognize something in this profile that can help find why the server had locked up a few times.

This started when logging in a player, other players were on the server, the server became 100% unresponsive ingame and on console, until that player quit his client, then it recovered.

net.minecraft.util.math.shapes.VoxelShapeSpliterator.func_234878_a_()70.21%70000ms

byg is the only biome mod in the modpack.

commented

It never crashed, it locked up hard, then recovered.

Here is a zip of the webpage with the warmroast profile.
Warmroast-webpage.zip

Logs.zip

commented

Warmroast and sampler are the only two things I have found to help diagnose a lockup, unfortunately, sampler isn't updated yet.

commented

Not sure how this is pointing to be BYG issue. Have you tested BYG on its own?

commented

We can't cleanly reproduce it, we can play for days then suddenly it locks hard on that VoxelShapeSpliterator, I was just hoping with Biome in the stacktrace you might recognize it.

commented

Send me the file in this screenshot on google drive. Also Send a latest.log and a crashlog(if applicable) too.

commented

It happened again -
image

commented

I've been asking around about this but no one cares enough to answer me. This most likely has to do with rendering of some sort.

commented

@ProsperCraft I have an idea of what it might be.... There might be a mod in your modpack that has a block larger than the block space. I read through the code a bit more and it makes sense.... You need to find that mod in question and report to them...

commented

Start with any mods in your pack that might have a piston like block

commented

What I mean larger than the 1x1 block space is like a hitbox/voxel shape is larger than the 1x1 block space. Basically, an oversized block voxel shape/hitbox

commented

Could this potentially be related to the vanilla structuregen deadlock? Might be worth running with the watchdog enabled to catch the state of all threads when locked

commented

Not sure if BYG's tall plants could be causing this... I'll check later today and make sure this isn't the case, bc we should be matching Vanilla's

commented

@ProsperCraft Im assuming you've found a solution?

commented

No, it still locks up.

commented

We'll wait til 1.16.4 and see what happens then... like Gegy mentioned, could be related to the deadlock.

commented

Could be related to the bug patched in 1.16.4: https://bugs.mojang.com/browse/MC-199487

commented

We have not had this issue since wiping the nether and end, will re-open if it happens again.