Oh The Biomes You'll Go Refabricated

Oh The Biomes You'll Go Refabricated

11M Downloads

Unlit Campfires Produce Light

Brittank88 opened this issue · 4 comments

commented

API/Modloader
Forge 36.1.16

Describe the bug
The mod's campfires produce light, even when unlit. This occurs even when BYG is the only installed mod.

To Reproduce

  1. Let there be dark.
  2. Place either a boric or cryptic campfire.
  3. Place water above it.
  4. Campfire still produces light.

Expected behavior
These campfires should only produce light if they are lit. This issue does not occur with other campfires, modded or unmodded.

Screenshots/Videos
image

Additional context
Interesting to note is that upon placing either of the campfires we see these sort of entries in the log:

[14:51:19] [Render thread/WARN] [minecraft/TileEntity]: Block entity invalid: minecraft:campfire @ BlockPos{x=-175, y=71, z=-48}
[14:51:20] [Server thread/WARN] [minecraft/TileEntity]: Block entity invalid: minecraft:campfire @ BlockPos{x=-175, y=71, z=-48}
[14:51:32] [Render thread/WARN] [minecraft/TileEntity]: Block entity invalid: minecraft:campfire @ BlockPos{x=-171, y=71, z=-48}
[14:51:32] [Server thread/WARN] [minecraft/TileEntity]: Block entity invalid: minecraft:campfire @ BlockPos{x=-171, y=71, z=-48}

Logs
Crashlog - N/A
Debug.log & Latest.log

commented

Also, may be related, specifically only BYG campfires do not produce smoke:
image

commented

fixed

commented

I'll go ahead and close the issue once I can verify it's working - unless you decide to close it first!

commented

fixed in upcoming update ( I will be closing as I need to keep track of what is fixed)