Oh The Biomes You'll Go Refabricated

Oh The Biomes You'll Go Refabricated

11M Downloads

[Bug]: End and Nether nylium blocks die when almost any block is placed on top

supermassimo opened this issue ยท 1 comments

commented

Mod Version

1.3.5

Mod Loader

Forge

Mod Loader Version

36.2.23

What happened?

Nylium blocks will die over time if any block is placed on them, even if they are not full blocks.
image

This is caused by the BYGNylium block class checking canOcclude() instead of checking the light transmittance level like vanilla nylium blocks.
Line of code responsable in BYGNylium:

        if (this.worldRegistryKey == World.END && world.getBlockState(pos.above()).canOcclude()) {
            world.setBlockAndUpdate(pos, this.dirtBlock.defaultBlockState());
        }

Line of code responsable for the correct behaviour in vanilla NyliumBlock:

      int i = LightEngine.getLightBlockInto(world, state, pos, blockstate, blockpos, Direction.UP, blockstate.getLightBlock(world, downPos));
      return i < world.getMaxLightLevel();

latest.log

latest.log

commented

Fixed in 1.18.2