Oh The Biomes You'll Go Refabricated

Oh The Biomes You'll Go Refabricated

12M Downloads

[Bug?]: End Stone Phylium/Phycelium tagged as minecraft:dirt, causing side effects

vectorwing opened this issue ยท 0 comments

commented

Minecraft Version

1.18.2

BYG Version

1.4.1

Terrablender Version

1.1.0.102

Mod Loader

Forge

Mod Loader Version

40.1.51

Bug Severity

Minor

What happened?

While troubleshooting a related issue with Farmer's Delight, I noticed that the Phylium/Phycelium series of blocks (growing on End Stone) are tagged as minecraft:dirt in the Forge version. There is an existing issue, #410, discussing this on the Fabric version for a different tag, but I figured I'd post a new one for additional context, due to that one's age.

Although this isn't really a bug, it sounds like an unintended tag assignment, as these blocks aren't actually dirt, but rather End Stone. By using this tag, the following side effects occur:

  • All Overworld plants can be planted on these blocks;
  • Vegetation features which check for the minecraft:dirt tag might end up generating in End biomes;
    • This is mostly an issue on FD's end, and I should be filtering out Nether and End biomes. Still, just a heads up, as other mods might do similar checks;
  • Growing Giant Spruce trees over Phylium causes it to become Podzol. This converts the End Stone into dirt irreversibly.

Here's a screenshot demonstrating some of them (clean End Stone added as an example of non-conversion):

image

latest.log

https://gist.github.com/vectorwing/a04876f9baad6c07522b425444ee7566

Did you isolate BYG?

I tried BYG alone