Oh The Biomes You'll Go Refabricated

Oh The Biomes You'll Go Refabricated

11M Downloads

[Bug]: Tree logs from this mod cannot be stripped

SatDog92 opened this issue ยท 2 comments

commented

Minecraft Version

1.19.2

BYG Version

2.0.0.8

Terrablender Version

0.0.117

Mod Loader

Quilt

Mod Loader Version

0.17.3

Bug Severity

Minor

What happened?

What the title says: on Quilt, tree log for this mod cannot be stripped at all. At first i though it was some mod conflict (even if other logs from other few mods worked properly), but i tried BYG alone and it appears it's just with Quilt. On Fabric it works fine, but since Quilt can be selected from this bug report guide, i thought it was appropriate reporting this.

latest.log

latest.log

Did you isolate BYG?

I tried BYG alone

EDIT: updated version, as it happens in 2.0.0.8 as well.

commented

To anyone looking into fixing this mod, and as one of the developers working on QSL here's why this bug happens:

Quilt has an API called Registry Entry Attachments, which allows to attach arbitrary objects to a registry entry, this API allows this to also be data-driven. This API is used for strippable logs as you can see here.
This means the unstripped -> stripped map is cleared at each data pack reload and it's happening after QSL initialization which means existing values are not caught and put into the REA.

Here's some possible fixes to consider:

  • abstract the implementation to allow to call Fabric API's strippable registry, which would fix this issue entirely
  • use the data-driven variant for Quilt (example.

In the mean time, as a mitigation of the issue, a custom data-pack could be created to re-add the missing entries.

commented

I'm still experiencing this problem, but only on multiplayer. It works fine on singleplayer.

Using:
Minecraft 1.19.2
Quilt Loader 1.17.8
QFAPI 4.0.0-beta.26 and QSL 3.0.0-beta.25
Terrablender 20.0.1.136
BYG 2.0.0.13

When I strip a log on a server it will momentarily look stripped (clientside stripping) and then instantly go back to unstripped. (server rejecting)

The server only has QFAPI, BYG, TerraBlender and Geckolib installed. As does the client. Configs are also identical between client and server.