[Suggestion] Compatibility with BetterNether
paulevsGitch opened this issue ยท 17 comments
Good day. I am author of BetterNether mod and I want to make a small suggestion about compatibility. As I can see nylium blocks from BYG doesn't have "minecraft:nylium" block tag, could you add it? This will allow plants to grow on them and will correct bonemeal effect. Thank you in advance
Wanted to ask, does my mixin into the nether biome provider work with your mod? And yes I'll get this fixed!
Looks like all other things works fine. Probably because of my own biome provider (something may generate wrong, I don't know what changes you made). If you are interesting I'm trying to cooperate with Cinderscapes developers to integrate my code and their code into unified biome library. And at this time I have a small API for advanced biome generation (like sub-biomes or edges)
There is an issue with biome generation. It appeared on latest version of BYG.
I think the best way to solve it is to add another condition with "betternether" here
Should be patched here:
https://www.curseforge.com/minecraft/mc-mods/oh-the-biomes-youll-go-fabric/files/2996610
LMK if it worked.
The last one tag is incorrect (must be "byg:nylium_soul_sand", with namespace)
P.S.: BetterNether also has a tag "common:soul_ground" for soul-sand-soil like blocks, can you add "Nylium Soul Sand" and "Nylium Soul Soil" into it?
https://github.com/CorgiTaco/BYG/tree/Fabric-1.16.X/src/main/resources/data/common/tags/blocks
does this look correct? Im new to this whole common/tag system
Should I add my nylium blocks that are literally netherrack but are a top block variant too the netherrack tag?
I think yes, this tag was created for all types of netherrack including nylium
Also My nether BP was pulling from fabric api's added nether biomes so thats odd.
https://www.curseforge.com/minecraft/mc-mods/oh-the-biomes-youll-go-fabric/files/2997209
LMK if it worked. It worked for me at least.