Oh The Biomes You'll Go

Oh The Biomes You'll Go

50M Downloads

[1.19][Bug]: Cherry foliage generating off-center and inside blocks

Maltshakes opened this issue ยท 3 comments

commented

BYG Version

2.0.0.13

Terrablender Version

2.0.1.129

Mod Loader

Forge

Mod Loader Version

43.1.30

Bug Severity

Minor

What happened?

While exploring the biomes, I came across the Cherry Blossom Forest and noticed some strange behavior with the fallen leaf piles. They were off-center, but also generating lower than their hitbox resulting in them being inside the block below them:
2022-11-06 11_49_07-Window

latest.log

latest.log

Did you isolate BYG?

I tried BYG alone

commented

I've also seen this happen with the other groundcover-type plants added in BYG like the fallen leaves and clover, it's just not as obvious as the full square cherry blossoms.

If the groundcovers are coded as flowers, I think it might be the randomized placement at work. It's obvious that the flowers are placed in random spots within the block, but I think they might also be sunk in by a pixel sometimes which just adds height variation in a sunflower but completely disappears something that's only one pixel tall to start with.

commented

Can confirm it's the randomized placement. The effect is easily tested with stained glass.

image
image

Affected blocks include Pink Cherry Foliage, White Cherry Foliage, Ether Foliage, Leaf Pile, Clover Patch, and Flower Patch.

commented

Fixed and will be patched in our upcoming update