Omni-Hopper

Hi, I found this nice mod and downloaded it but when I joined my world, I immediately received this message in the chat which concerns me on upcoming crashings:

Error on retrieving server data from provider
mcp.mobius.waila.plugin.textile.provider.FluidStorageProvider$$Lambda$15031/0x0000000801cf8000

I can try to find the cause if you send a full log that includes this error. It's probably harmless though, so I wouldn't worry about it.

The issue is on here

OmniHopper/src/main/java/nl/enjarai/omnihopper/mixin/AbstractFurnaceBlockEntityMixin.java

Lines 37 to 42 in 6028755

    
           public @Nullable Storage<FluidVariant> getFluidStorage(Direction side) { 
        
               if (side.getAxis().isHorizontal()) { 
        
                   return fluidStorage; 
        
               } 
        
               return null; 
        
           }

On 1.20, FAPI's ItemStorage.SIDED and FluidStorage.SIDED allows for null side. The method on SidedStorageBlockEntity is not marked as such though (it's an oversight).

FabricMC/fabric#3281
badasintended/wthit#231

Oh I see, thanks for letting me know! I'll push an update to implement a null check.

oh well, guess I don't have to explain further

	public @Nullable Storage<FluidVariant> getFluidStorage(Direction side) {
	if (side.getAxis().isHorizontal()) {
	return fluidStorage;
	}
	return null;
	}

Share to