Open Glider

Open Glider

8M Downloads

[1.10.2 - 1.0.0] Other players don't see equipped glider

rinart73 opened this issue ยท 5 comments

commented

Not a modpack. List of mods:
Advanced Solar Panels-4.0.4.jar
ArsMagica2-1.10.2-1.5.0-18.jar
astralsorcery-1.4.4.jar
BiblioCraft[v2.2.4][MC1.10.2].jar
CoralReef-1.2.jar
CraftTweaker-1.10.2-3.0.26.jar
CyclopsCore-1.9.4-0.10.6.jar
dailies-1.10.2-6.jar
EverlastingAbilities-1.9.4-1.2.4.jar
gravestone-1.5.13.jar
industrialcraft-2-2.6.245-ex110.jar
InventoryTweaks-1.61-58.jar
ironchest-1.10.2-7.0.15.804.jar
jei_1.10.2-3.14.7.420.jar
liteloader-1.10.2-release.jar
Mantle-1.10.2-1.1.5.jar
missing_pieces-1.10.2-4.3.0.jar
mod_voxelMap_1.6.23_for_1.10.2.litemod
MouseTweaks-2.8-mc1.10.2.jar
OpenGlider-1.10.2-1.0.0.jar
OptiFine_1.10.2_HD_U_E3.jar
RoguelikeDungeons-1.10.2-1.5.9.jar
Waila-1.7.0-B3_1.9.4.jar
Wawla-1.10.2-2.3.2.215.jar
WTF-Expedition-WorldGen_1.10.2_-v1.5.1.jar
[1.9.4]Mo' Villages-1.5.2.jar

Issue Description:

Other players don't see a glider when it's equippied

What happens:

When someone "holds" glider (chooses it on a toolbar) other players see it. But when it's equipped or someone flies with it equipped, other players don't see the glider.

What you expected to happen:

I expect other players to see how I'm using the glider and being cool.

Steps to reproduce (important):

  1. Equip a glider
  2. Fly
  3. Ask someone else to look at you
    ...

Affected Versions (Do not use "latest". Forge version is nice, but not usually necessary.):

  • OpenGlider: 1.0.0
  • Minecraft: 1.10.2
  • Forge: 1.10.2-12.18.3.2185
commented

Hmm, a couple questions:

  • Does it render for you in 3rd person perspective?
  • Do you have a skinny player model?
commented
  • Yes, on my side everything is ok. I suppose if someone other will user glider, it will be fine for them too.
  • Skinny? If you're asking about custom player model then no, default model. In cause you meant something else (custom skin) - Yes, I do. I use Ely.by skin. Other player see it.
commented

It's definetily caused by the slim skin (Alex) and is the same thing that affects #8. I fixed it (very simple fix), but after that I noticed that only the Advanced Glider is visible to others. Both gliders are now visible to the user though, regardless of the skin model.

Can @gr8pefish clarify if there's some kind of network handling separately for those?

commented

From a quick skim of the source I don't believe so. I believe I tried a quick fix for #8 and couldn't figure it out so dropped it in favor of other work. That being said, I could be misremembering as it's been years since I messed with this.

commented

Actually it works on Alex too now, don't know why it didn't show earlier. The fix is also very simple and the bug is caused by poor coding on Minecraft itself. I'll create a pull request tomorrow or maybe today, if you want.