Player health issue possibly?
mojoyup1528 opened this issue ยท 2 comments
Player health is knocked down to 1 heart or 1/2 heart when landing normal no collisions other than grass blocks
Issue Description: Hang Glider in hand player hits ground loses almost all health
What happens: The injury to player sound is activated and player hearts go to 1/2 - 1
What you expected to happen: Player does not lose health, only maybe hunger or thirst etc
Steps to reproduce (important):
- Jump from height above 62 (water level nominal height)
- glide to land based at 60-63 height while doing cirlces
- land while turning - maybe the issue?
...
Affected Versions (Do not use "latest". Forge version is nice, but not usually necessary.):
- OpenGlider: 1.12.1-1.1.0
- Minecraft: 1.12.2
- Forge: 1.12.2 14.23.4.2705
NOTE: I know the version of glider is 1.12.1 but it works great and is the one that downloaded for me when I chose version :) Maybe there is a 1.12.2 that I missed?
AWESOME MOD btw!!!!!!! Will consider donating :)
Going to post my findings here rather than creating a new issue, as I think it's related:
I've repeatedly taken fall damage when landing with the hang glider in my singleplayer world, even to the point of killing me instantly (20+ hearts of damage dealt). Now, I haven't seen the code behind it but I think what's happening is the glider is trying to negate fall damage when landing, but fails to do so when the server instance is lagging. What might be happening is that, in such cases, the fall damage is dealt to the player before Open Glider had a chance to cancel it.
I later tried to confirm this hypothesis by flying off a tall mountain into ungenerated terrain, to force my singleplayer game to experience heavy TPS drop (it helps if you have additional structure generation such as Ancient Warfare, and a high rendering distance). Without fail, I would immediately die the moment I touched the ground (while still using the glider!). On later attempts of reproducing that flight - in the same world - I no longer lost health, as the terrain was now fully generated, and thus my TPS remained stable.
