Open Terrain Generator (OTG)

Open Terrain Generator (OTG)

10M Downloads

No stongholds are generated, /locate not working.

lenzls opened this issue ยท 3 comments

commented

Hello,

I'm playing for half a year now in a biome bundle world.
A few days ago, we realized that we can't find a stronghold with enderpearls. Then I double checked with /locate stronghold and the servers tells me then Unable to locate any stronghold feature

So it seems there are no strongholds generated in my world?

When I look at <serverdir>/plugins/OpenTerrainGenerator/worlds/<biomebundle-world>/WorldConfig.ini, I see the following lines:

[..]
###############
# Strongholds #
###############
StrongholdsEnabled: true
StrongholdCount: 128
StrongholdDistance: 32.0
StrongholdSpread: 3
[..]

So it seems regarding my configuration, it should generate strongholds.

Our server a normal Spigot 1.12.2. Plugins I'm using:

CleanroomGenerator.jar
CreeperHeal-7.0.5.jar
JourneyMapServer1.01_Bukkit_MC1.9.jar
MobCatcherLite.jar
Multiverse-Core-2.5.0.jar
Multiverse-NetherPortals-2.5.2-SNAPSHOT.jar
Multiverse-Portals-2.5.0.jar
'OpenTerrainGenerator-1.12.2 - v4.jar'
perworldinventory-1.11.1.jar
'SimpleFly - 1.1.jar'
worldedit-bukkit-6.1.7.3.jar
worldguard-6.2.1.jar

@MCPitman suggested to post this as a bug here and wondered if this could be something related to the multiverse plugin.

Therefore here is an excerpt of my <serverdir>/plugins/Multiverse-Core/worlds.yml. I removed all world except my biomebundle world and a vanilla world as an example.

worlds:
  biomebundle:
    ==: MVWorld
    hidden: 'false'
    alias: biomebundle
    color: WHITE
    style: NORMAL
    pvp: 'true'
    scale: '1.0'
    respawnWorld: ''
    allowWeather: 'true'
    difficulty: EASY
    spawning:
      ==: MVSpawnSettings
      animals:
        ==: MVSpawnSubSettings
        spawn: 'true'
        spawnrate: '-1'
        exceptions: []
      monsters:
        ==: MVSpawnSubSettings
        spawn: 'true'
        spawnrate: '-1'
        exceptions: []
    entryfee:
      ==: MVEntryFee
      amount: '0.0'
      currency: '-1'
    hunger: 'true'
    autoHeal: 'true'
    adjustSpawn: 'true'
    portalForm: ALL
    gameMode: SURVIVAL
    keepSpawnInMemory: 'true'
    spawnLocation:
      ==: MVSpawnLocation
      x: -81.5
      y: 64.0
      z: -1327.5
      pitch: 0.0
      yaw: 0.0
    autoLoad: 'true'
    bedRespawn: 'true'
    worldBlacklist: []
    environment: NORMAL
    seed: '-1855594102007842951'
    generator: OpenTerrainGenerator
    playerLimit: '-1'
    allowFlight: 'true'
  world:
    ==: MVWorld
    hidden: 'false'
    alias: world
    color: WHITE
    style: NORMAL
    pvp: 'true'
    scale: '1.0'
    respawnWorld: ''
    allowWeather: 'true'
    difficulty: EASY
    spawning:
      ==: MVSpawnSettings
      animals:
        ==: MVSpawnSubSettings
        spawn: 'true'
        spawnrate: '-1'
        exceptions: []
      monsters:
        ==: MVSpawnSubSettings
        spawn: 'true'
        spawnrate: '-1'
        exceptions: []
    entryfee:
      ==: MVEntryFee
      amount: '0.0'
      currency: '-1'
    hunger: 'true'
    autoHeal: 'true'
    adjustSpawn: 'true'
    portalForm: ALL
    gameMode: SURVIVAL
    keepSpawnInMemory: 'true'
    spawnLocation:
      ==: MVSpawnLocation
      x: -85.0
      y: 80.0
      z: 377.0
      pitch: 0.0
      yaw: 0.0
    autoLoad: 'true'
    bedRespawn: 'true'
    worldBlacklist: []
    environment: NORMAL
    seed: '3946264639521290473'
    generator: 'null'
    playerLimit: '-1'
    allowFlight: 'true'
[..]

What could go wrong here?

commented

Hey @lenzls, I'm currently testing and wrapping up some other things, so if you could do some legwork for me that would help. Could you try generating a new default OTG world and see if it has strongholds, once with and once without multiverse? And if find that OTG+MV is causing problems, could you check if it only happens in MV dimensions or also in the overworld? Thanks!

commented

First things first:
I realized that I was using the wrong command. I used /locate stronghold which does not find anything in every world. Correct would be /locate Stronghold!

With that command, I'm getting the following error on my server:

[23:52:05 INFO]: Player issued server command: /locate Stronghold
[23:52:05 WARN]: Unknown CommandBlock failed to handle command
java.lang.NullPointerException: null
	at net.minecraft.server.v1_12_R1.WorldGenStronghold.c(SourceFile:106) ~[spigot-1.12.2.jar:git-Spigot-5695bca-53fccdf]
	at net.minecraft.server.v1_12_R1.WorldGenStronghold.getNearestGeneratedFeature(SourceFile:58) ~[spigot-1.12.2.jar:git-Spigot-5695bca-53fccdf]
	at com.pg85.otg.bukkit.generator.OTGInternalChunkGenerator.findNearestMapFeature(OTGInternalChunkGenerator.java:74) ~[?:?]
	at net.minecraft.server.v1_12_R1.ChunkProviderServer.a(ChunkProviderServer.java:338) ~[spigot-1.12.2.jar:git-Spigot-5695bca-53fccdf]
	at net.minecraft.server.v1_12_R1.WorldServer.a(WorldServer.java:1420) ~[spigot-1.12.2.jar:git-Spigot-5695bca-53fccdf]
	at net.minecraft.server.v1_12_R1.CommandLocate.execute(SourceFile:39) ~[spigot-1.12.2.jar:git-Spigot-5695bca-53fccdf]
	at org.bukkit.craftbukkit.v1_12_R1.command.VanillaCommandWrapper.dispatchVanillaCommand(VanillaCommandWrapper.java:109) [spigot-1.12.2.jar:git-Spigot-5695bca-53fccdf]
	at org.bukkit.craftbukkit.v1_12_R1.command.VanillaCommandWrapper.execute(VanillaCommandWrapper.java:38) [spigot-1.12.2.jar:git-Spigot-5695bca-53fccdf]
	at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:141) [spigot-1.12.2.jar:git-Spigot-5695bca-53fccdf]
	at org.bukkit.craftbukkit.v1_12_R1.CraftServer.dispatchCommand(CraftServer.java:651) [spigot-1.12.2.jar:git-Spigot-5695bca-53fccdf]
	at net.minecraft.server.v1_12_R1.PlayerConnection.handleCommand(PlayerConnection.java:1392) [spigot-1.12.2.jar:git-Spigot-5695bca-53fccdf]
	at net.minecraft.server.v1_12_R1.PlayerConnection.a(PlayerConnection.java:1227) [spigot-1.12.2.jar:git-Spigot-5695bca-53fccdf]
	at net.minecraft.server.v1_12_R1.PacketPlayInChat.a(PacketPlayInChat.java:45) [spigot-1.12.2.jar:git-Spigot-5695bca-53fccdf]
	at net.minecraft.server.v1_12_R1.PacketPlayInChat.a(PacketPlayInChat.java:1) [spigot-1.12.2.jar:git-Spigot-5695bca-53fccdf]
	at net.minecraft.server.v1_12_R1.PlayerConnectionUtils$1.run(SourceFile:13) [spigot-1.12.2.jar:git-Spigot-5695bca-53fccdf]
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) [?:1.8.0_162]
	at java.util.concurrent.FutureTask.run(FutureTask.java:266) [?:1.8.0_162]
	at net.minecraft.server.v1_12_R1.SystemUtils.a(SourceFile:46) [spigot-1.12.2.jar:git-Spigot-5695bca-53fccdf]
	at net.minecraft.server.v1_12_R1.MinecraftServer.D(MinecraftServer.java:748) [spigot-1.12.2.jar:git-Spigot-5695bca-53fccdf]
	at net.minecraft.server.v1_12_R1.DedicatedServer.D(DedicatedServer.java:406) [spigot-1.12.2.jar:git-Spigot-5695bca-53fccdf]
	at net.minecraft.server.v1_12_R1.MinecraftServer.C(MinecraftServer.java:679) [spigot-1.12.2.jar:git-Spigot-5695bca-53fccdf]
	at net.minecraft.server.v1_12_R1.MinecraftServer.run(MinecraftServer.java:577) [spigot-1.12.2.jar:git-Spigot-5695bca-53fccdf]
	at java.lang.Thread.run(Thread.java:748) [?:1.8.0_162]


On your questions:

I hope that I got you right. With

a new default OTG world

you still mean with some preset right?

I created a new folder and put my spigot jar in it.
Then i created a plugins folder and put OTG in it. Run the server once, quit. Then I put the biomebundle files in the plugins/OTG folder. Adopted server.properties and buckit.yml according to this and started again.

It was a biome bundle world and /locate Stronghold returned coordinates!. It seems to work in this case.

Then I also put multiverse in the plugins folder and created a copy of <server-dir>/plugins/OpenTerrainGenerator/worlds/Biome Bundle/ to <server-dir>/plugins/OpenTerrainGenerator/worlds/aaa/ and tried to generate the world with multiverse. I get the following error:

>mv create aaa NORMAL -g OpenTerrainGenerator
[00:25:39 INFO]: [OTG] 62 biomes Loaded
[00:25:39 INFO]: CONSOLE: Starting creation of world 'aaa'...
[00:25:39 WARN]: Unexpected exception while parsing console command "mv create aaa NORMAL -g OpenTerrainGenerator"
org.bukkit.command.CommandException: Unhandled exception executing command 'mv' in plugin Multiverse-Core v2.5.0-b727
	at org.bukkit.command.PluginCommand.execute(PluginCommand.java:46) ~[spigot-1.12.2.jar:git-Spigot-5695bca-53fccdf]
	at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:141) ~[spigot-1.12.2.jar:git-Spigot-5695bca-53fccdf]
	at org.bukkit.craftbukkit.v1_12_R1.CraftServer.dispatchCommand(CraftServer.java:651) ~[spigot-1.12.2.jar:git-Spigot-5695bca-53fccdf]
	at org.bukkit.craftbukkit.v1_12_R1.CraftServer.dispatchServerCommand(CraftServer.java:637) [spigot-1.12.2.jar:git-Spigot-5695bca-53fccdf]
	at net.minecraft.server.v1_12_R1.DedicatedServer.aP(DedicatedServer.java:444) [spigot-1.12.2.jar:git-Spigot-5695bca-53fccdf]
	at net.minecraft.server.v1_12_R1.DedicatedServer.D(DedicatedServer.java:407) [spigot-1.12.2.jar:git-Spigot-5695bca-53fccdf]
	at net.minecraft.server.v1_12_R1.MinecraftServer.C(MinecraftServer.java:679) [spigot-1.12.2.jar:git-Spigot-5695bca-53fccdf]
	at net.minecraft.server.v1_12_R1.MinecraftServer.run(MinecraftServer.java:577) [spigot-1.12.2.jar:git-Spigot-5695bca-53fccdf]
	at java.lang.Thread.run(Thread.java:748) [?:1.8.0_162]
Caused by: java.lang.AssertionError: Biome ID #165 returns custom biome #425 instead of its own.
	at com.pg85.otg.bukkit.OTGBiomeBase.checkRegistry(OTGBiomeBase.java:153) ~[?:?]
	at com.pg85.otg.bukkit.OTGBiomeBase.createInstance(OTGBiomeBase.java:141) ~[?:?]
	at com.pg85.otg.bukkit.BukkitBiome.forCustomBiome(BukkitBiome.java:43) ~[?:?]
	at com.pg85.otg.bukkit.BukkitWorld.createBiomeFor(BukkitWorld.java:171) ~[?:?]
	at com.pg85.otg.bukkit.BukkitWorld.createBiomeFor(BukkitWorld.java:1646) ~[?:?]
	at com.pg85.otg.configuration.ServerConfigProvider.indexSettings(ServerConfigProvider.java:264) ~[?:?]
	at com.pg85.otg.configuration.ServerConfigProvider.loadBiomes(ServerConfigProvider.java:135) ~[?:?]
	at com.pg85.otg.configuration.ServerConfigProvider.loadSettings(ServerConfigProvider.java:79) ~[?:?]
	at com.pg85.otg.configuration.ServerConfigProvider.<init>(ServerConfigProvider.java:68) ~[?:?]
	at com.pg85.otg.bukkit.OTGPlugin.getDefaultWorldGenerator(OTGPlugin.java:137) ~[?:?]
	at org.bukkit.WorldCreator.getGeneratorForName(WorldCreator.java:311) ~[spigot-1.12.2.jar:git-Spigot-5695bca-53fccdf]
	at org.bukkit.WorldCreator.generator(WorldCreator.java:183) ~[spigot-1.12.2.jar:git-Spigot-5695bca-53fccdf]
	at com.onarandombox.MultiverseCore.utils.WorldManager.addWorld(WorldManager.java:240) ~[?:?]
	at com.onarandombox.MultiverseCore.commands.CreateCommand.runCommand(CreateCommand.java:114) ~[?:?]
	at com.pneumaticraft.commandhandler.multiverse.CommandHandler.checkAndRunCommand(CommandHandler.java:279) ~[?:?]
	at com.pneumaticraft.commandhandler.multiverse.CommandHandler.processFoundCommands(CommandHandler.java:143) ~[?:?]
	at com.pneumaticraft.commandhandler.multiverse.CommandHandler.locateAndRunCommand(CommandHandler.java:93) ~[?:?]
	at com.onarandombox.MultiverseCore.MultiverseCore.onCommand(MultiverseCore.java:919) ~[?:?]
	at org.bukkit.command.PluginCommand.execute(PluginCommand.java:44) ~[spigot-1.12.2.jar:git-Spigot-5695bca-53fccdf]
	... 8 more

I sadly can't remember how I created my current world with multiverse back in the day, but I thought it was this way. Did I do something wrong?

I think I need a little closer guidance on what I need to do :/

regards

commented

Have tested with v7_r25 new Biome Bundle world. /locate Stronghold works and a stronghold is generated. If you can reproduce this when creating a new world, feel free to re-open this issue. Can't help with the existing world unfortunately.