Open Terrain Generator (OTG)

Open Terrain Generator (OTG)

10M Downloads

Bug: 1.16 - issues with objects and structures

BiomeBundle opened this issue ยท 10 comments

commented
  • Entity() not working
  • NBT not working on objects (even for chests, which work for structures)
  • NBT not working on anything other than chests in structures (e.g. flower pots, furnaces, dispensers, signs, cauldrons, etc)
commented

Got 'er done

commented

Still TODO:

  • Entity (forge done, spigot still todo)
  • DOUBLE_PLANT:2 is supposed to be double_tall_grass but isnt
  • Normal skulls generating as wither skulls
  • "Could not parse block STAINED_GLASS_PANE, substituting with air" * Fixed
commented

TODO

  • Will need to fix double plants in bo's via /otg edit, as they were one block before, but are now two. Doors / beds should also be looked at, not sure if they were picked up with connecting blocks fixes. * Fixed

  • Grass(), Plant() and UnderWaterPlant() recognise the list of aliases for PlantType, so can spawn double plants. SurfacePatch does not use it though, so will need to, also old aliases should be automatically converted to PlantType aliases when parsing settings *except for bo's. * Fixed

  • Skull may be a problem due to overlapping aliases, if I recal correctly, the old name for skull now means wither skull.

  • Entity() works for Forge, Spigot has the exact same code which seems to work when inspected with breakpoints etc, but no mobs appear in the world.

  • NBT for chests using numerical block/item id's should be auto-corrected to use new block/item registry names. We have not looked at nbt files using legacy block names though, those likely also need to be parsed and updated.

commented

Double tall plants, doors and the like should already be fixed by /otg edit. If they're not, just need to add them to the list of blocks to update, I believe

commented

Grass(), Plant(), UnderWaterPlant() and SurfacePatch() should now pick up / write back PlantType aliases, should pick up double_plant:x and minecraft:double_plant:x (case-insensitive).

commented

Entity() is now fixed.

commented

DOUBLE_PLANT:2 is supposed to be double_tall_grass but isnt

commented

Normal skulls generating as wither skulls

commented

"Could not parse block STAINED_GLASS_PANE, substituting with air"

commented

Well, this was a long one. But the last issue before 0.1.0 has been resolved! I finished it off by getting skulls and pots to work.