OTG + TF: Biome cast crash for 1.12.2 v2
MCPitman opened this issue · 6 comments
Looks like TF is making the assumption that the class of a biome it has a reference to is analogous to the vanilla forest biome's class, which in this case isn't true. Could fix that on the OTG end by making sure that any biome that replaces a vanilla biome uses a class that inherits from the vanilla biome's class. Would be a lot of work though and shouldn't really be necessary, it would be better if TF used another way to determine whether the biome it has a reference to is really a forest biome. I also wonder why TF needs to cast the biome to a Forest, that should only be necessary if the Forest class exposes members that its superclasses don't. Usually you can make due just refering to biomes as biomes, no need to be more specific, the biome class exposes all the necessary functions. Will take a look at TF's source code later to see what they're doing.
If you are going to replace instances, you need to maintain hierarchy. This is not something for TF to fix.
Oh nice same problem tehre.
Logs
Related to #104, will close this issue and continue there.