OpenBlocks

OpenBlocks

56M Downloads

Sprinklers particles go backwards

mikeemoo opened this issue ยท 5 comments

commented

In certain directions the sprinkler fires particles backwards (not in sync with the sprinkler bar). This needs to be reversed

commented

Right so my thoughts are that the server should just apply sprinkler logic to blocks in a radius, as for the rotation + the particles. That should be 100% client side either based on totalWorldTicks or tileEntity ticks.

So we can get rid of isClockwise because there is no reason that the server needs to know that. Particles don't actually do anything other than look wonderful, so that can stay client side. :)

commented

Right, so this is a big change as I want to remove everything except the enabled flag for this; and move all the particle code and rotation code client side. I can't do that without being able to run the mod, so this will have to wait until later tonight :)

commented

rotation wrap around, or incorrect math somewhere. I will have a look.

commented

Just occurred to me that rotation is block rotation only, and the pitch is calculated by ticks since changed haha

commented

The ForgeDirection handed to the particle method is probably off by 90 degrees, as I just passed it the sprinkler rotation when testing.

This wont matter for now, but should be fixed sometime in the future if we want to repurpose that particle code.