OpenBlocks

OpenBlocks

56M Downloads

1.7.10 openblocks stops ExU wings from rendering

Renvolt opened this issue ยท 4 comments

commented

spent about an hour testing and I traced the issue with the extra utilities wings not rendering to open blocks. I also determined the cause to be the setting in the configs under hacks labeled "tryHookPlayerRenderer" when set to false the issue stops existing. using openblocks snapshot 430 and openmodslib snapshot 223.

commented

We hijack the player renderer to render custom animations for the hang glider, clearly ExU also hacks the renderer. The config option is there for this purpose, to disable the hack on our side to allow another mod to do so. Clearly both mods are doing something ugly, but at the time of implementation there was no other option.

I'll flick through ExU's source as well as Forge, and see if there is a better way. It might just be a case of, it's quirky behaviour and that is why there is a config option for it.

commented

With that said, the only method we utilize is rotateCorpse, so RWTema could check if the class is either Mojangs or ours, if it's ours, just extend ours. It's an option.

Like I said though, I'll look for a more solid solution, but some cooperation between the mods will need to occur

commented

I wasn't sure who's side it would be on but I went with letting you know. If you want ill report it to Temma as well on his github

commented

Hmm, looks like this issue was fixed for some time and should be closed.

Anyway, I used it as motivation for a57841f - we now no longer replace player render. Should fix any other compatibility issues.