openmods:id_injector - duplicate handler name on handshake reset
Opened this issue · 22 comments
http://i.nentify.me/CTKYy1cX.png
http://i.nentify.me/SYJrQsxk.png
This occurs when switching servers on a Bungee server using the OpenModsLib and OpenBlocks mods on 1.7.10.
Latest Cauldron, Bungee and Bungee-compatible FML/Forge builds. I can get specific numbers if necessary, or if changes have been made here already.
Thanks!
Well, what interest me is OpenModsLib snapshot number (OpenMods/OpenModsLib#21). It's probably Bungee screwing up channel registration, but I need confirmation.
OpenBlocks-1.7.10-1.3-snapshot-434.jar
OpenModsLib-1.7.10-0.6-snapshot-224.jar
Ehhhh, looks like something is messing with order of packets. I don't have idea, how exactly Bungee works, so this one may take a while.
Forge was recently updated to allow servers/Bungee to reset the handshake or something, perhaps it's related to this? I'm not sure specifically how you handle IDs though.
Uh, probably biggest problem right now is that I don't have any test setup, and I know almost nothing about Bungee
I could zip some files up for you with a setup if you want, or give you the modpack/IP for our test Bungee network
Sent zip on IRC.
- Start up all 3 instances (start.sh in each folder)
- Connect to IP on default port
- Use the "/server server2" command to switch servers
I'll be in IRC if you need anything. ^^
Hi guys,
I was wondering is there any update on this situation, I have the same problem myself and will be willing to test versions on my test bungee and cauldron server.
No new updates. I debugged stuff on setup provided by @Nentify and it looks like Bungee messes order of few key messages. I'm still not sure, if it's our bug (and how can we even fix) or theirs.
What a great idea! If I change name it will stop conflicting with itself!
Sorry for sarcasm, but this is just hilarious.
Anyway, for anyone interested in technical cause: REGISTER
packet (earliest one mod can handle) is normally sent together with ServerHello
, but when using Bungee it's somehow pushed long after ModIdData
(which is main target of this handler). Handler has no chance to work and remove itself, so next registration will fail.
None
On 10 Oct 2014 11:37, Parker Young [email protected] wrote:
What other mods have this issue?
Reply to this email directly or view it on GitHub:
#498 (comment)
I have reproduced new errors on a newer forge version (1217)
Client Crash: http://pastebin.com/YJt5RT4D
Server Error: http://pastebin.com/GSKuN4E4
Hope this can help 😿
Great news. Thanks @dualspiral!
It is BungeeCord issue, fortunately it's almost fixed. Once SpigotMC/BungeeCord#1256 is merged, switching servers will start to work.
Big thanks to @dualspiral for fixing this issue!
Update: I finally found solution that works with unpatched proxy. Please test with OpenModsLib snapshot 243 or later. Sorry it took so long.