OpenBlocks

OpenBlocks

56M Downloads

Items from TCon's inventory (including items in knapsack) have high chance not to drop when using OpenBlocks grave

Meegooo opened this issue ยท 7 comments

commented

After this fix i dont know on which side the problem is. So reporting on both sides

TCon 1.7.0d3.1
OpenBlocks .434
Forge .1208
Singleplayer

SlimeKnights/TinkersConstruct#1061

commented

It's duplicate continuation of #487. Thanks for referencing TiC issue

commented

It's not quite duplicate. It used to dupe, after fix on TCon side it doesnt drop at all (just destroys all items) with about 95% chance .
#487 in TCon repo is here

UPD: Woops, wrong button

commented

Yeah, sorry for that, I noticed this after posting. Will look at it later today. Looks like logic between OB, TiC and vanilla is somehow complicated right now.

commented

Ok.

For reference, here is our handler. It just makes copy of all EntityItems in PlayerDropsEvent, clears list and aborts event. Notice EventPriority.LOW on handler - it should execute after normal ones.

commented

@bonii-xx while debugging I found possible cause in TiC: TPlayerStats.copyFrom copies armor and knapsack inventories without updating .parent member on both objects, so after first death drops are added to EntityPlayer.capturedDrops belonging to invalid entity. It probably wouldn't even drop normally.

commented

Send me a message on IRC or just post it here if the problem is on Tinkers end. I didn't do the fix, but I can forward it I guess.

commented

Wow, that's evil. @Qowyn is taking a look at it now. :I