Off-by-one error in TileEntityElevator.java

Question

credomane opened this issue 11 years ago · 2 comments

credomane commented 11 years ago

Assuming the default searchDistance is 20 blocks.
If I set a elevator block at y=20 then another at y=40 then the elevator block will not function.

Looking at the source shows that at line 128 the loop stops one block short of checking the max distance.

"y < Config.elevatorTravelDistance" vs "y <= Config.elevatorTravelDistance".

nevercast · Answer 1 · 2013-09-05T02:06:23.000Z

Obviously I'll look more in to this issue, but for now I trust your judgement and this should be a quick fix for the moment.

credomane · Answer 2 · 2013-09-05T02:08:34.000Z

That was fast! Thanks!