OpenBlocks

OpenBlocks

56M Downloads

Leak caused by OpenBlocks?

TheRealDadbeard opened this issue ยท 3 comments

commented

Not quite sure but I have some issues on my server and just want to sort out if openblocks causes me issues

https://pastebin.com/Z0PiPLws

commented

Fixed first part in OpenMods/OpenModsLib@777ea74.

As for second part (*OutboundHandler), I'm not able to reproduce it, so I'm skipping that.

@bs2609 Do you know what is supposed to decrement FMLProxyPacket.payload reference count? I can't find any instance of that (definitely not actual sending, since toS3FPackets creates new buffers and toC17Packet is not problem, since we only send one that one once per message). NetworkDispatcher.sendProxy does not seem to change ref count, even when running test from MinecraftForge/MinecraftForge#4536, so I don't see why this extra reference count management is needed.