OpenBlocks

OpenBlocks

56M Downloads

Skyblock doesn't render properly with Better Portals

Johni0702 opened this issue ยท 0 comments

commented

See Johni0702/BetterPortals#312

BP hijacks the normal rendering by intercepting the call to EntityRenderer.renderWorld.
Then, when a portal is in frame, BP will first render the world inside the portal which will reset the lastRenderUsers counter to 0 (and it'll stay at 0 if there are no skyblocks in the nether) before rendering the main world where it will then cause the extra sky pass to be skipped.

// There may be single frame, when we have users, but no sky. That's acceptable IMO
skyCaptured = lastRenderUsers > 0;
if (!skyCaptured) return;
lastRenderUsers = 0;

The simplest way to fix this is to reset the lastRenderUsers counter every tick instead of every frame.