Potential incompatibility with Dynamic Surroundings

Question

Potential incompatibility with Dynamic Surroundings

asiekierka opened this issue 6 years ago · 9 comments

asiekierka commented 6 years ago

    at net.minecraft.world.ChunkCache.getLightForExt(ChunkCache.java:133)
    at net.minecraft.world.ChunkCache.getCombinedLight(ChunkCache.java:79)
    at org.blockartistry.lib.chunk.PassThroughChunkCache.getCombinedLight(PassThroughChunkCache.java:108)
    at org.blockartistry.DynSurround.client.fx.particle.mote.MoteParticle.getBrightnessForRender(MoteParticle.java:160)
    at org.blockartistry.DynSurround.client.fx.particle.mote.MoteParticle.updateBrightness(MoteParticle.java:110)
    at org.blockartistry.DynSurround.client.fx.particle.mote.MoteParticle.onUpdate(MoteParticle.java:102)
    at org.blockartistry.DynSurround.client.fx.particle.mote.MoteAgeable.onUpdate(MoteAgeable.java:58)
    at org.blockartistry.DynSurround.client.fx.particle.mote.ParticleCollection.lambda$static$0(ParticleCollection.java:56)
    at org.blockartistry.lib.collections.ObjectArray.removeIf(ObjectArray.java:79)
    at org.blockartistry.DynSurround.client.fx.particle.mote.ParticleCollection.onUpdate(ParticleCollection.java:112)
    at net.minecraft.client.particle.ParticleManager.tickParticle(ParticleManager.java:238)
    at net.minecraft.client.particle.ParticleManager.tickParticleList(ParticleManager.java:224)
    at net.minecraft.client.particle.ParticleManager.updateEffectLayer(ParticleManager.java:208)
    at net.minecraft.client.particle.ParticleManager.updateEffects(ParticleManager.java:164)
    at net.minecraft.client.Minecraft.runTick(Minecraft.java:1900)
    at net.minecraft.client.Minecraft.runGameLoop(Minecraft.java:1097)
    at net.minecraft.client.Minecraft.run(Minecraft.java:3940)
    at net.minecraft.client.main.Main.main(SourceFile:123)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:498)
    at net.minecraft.launchwrapper.Launch.launch(Launch.java:135)
    at net.minecraft.launchwrapper.Launch.main(Launch.java:28)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:498)
    at org.multimc.onesix.OneSixLauncher.launchWithMainClass(OneSixLauncher.java:196)
    at org.multimc.onesix.OneSixLauncher.launch(OneSixLauncher.java:231)
    at org.multimc.EntryPoint.listen(EntryPoint.java:143)
    at org.multimc.EntryPoint.main(EntryPoint.java:34)```

Barteks2x · Answer 1 · 2018-07-31T22:51:16.000Z

Did it crash? If it didn't, it should be fine. ChunkCache is modified my CC.

asiekierka · Answer 2 · 2018-08-01T05:25:09.000Z

It did crash, or at least VanillaFix caught it as a crash.

Rongmario · Answer 3 · 2018-08-01T03:08:31.000Z

OreCruncher/DynamicSurroundings#229
OreCruncher/DynamicSurroundings#330

Edit: My bad, looks like a new crash

Dinolek · Answer 4 · 2018-10-22T17:38:42.000Z

You need to disable DS caching in config after this commit.
This line is not used anymore after this.

pressRtowin · Answer 5 · 2019-06-11T13:33:37.000Z

This issue is still open, as a new (or previously unmentioned bug) has arisen that causes the world to hang indefinitely when entering the nether with both CC and DS. I've commented on the corresponding issue at DS here: OreCruncher/DynamicSurroundings#229

Barteks2x · Answer 6 · 2019-06-11T13:49:23.000Z

I've seen it. It's unlikely there is anything I can do about it, but I will have to see what causes it.

MrLightningBlaze · Answer 7 · 2019-09-19T12:28:28.000Z

So, running Forge 14.2.3.5.2847 and Cubic Chunks 0.0.1003.0-SNAPSHOT-all with dynamic surroundings 3.5.4.3 I have seen no sign of this issue whatsoever and did absoultely no config whatsoever, is it fixed?

Barteks2x · Answer 8 · 2019-09-19T12:34:12.000Z

There have been reports of severe performance issues in the nether. I'm not sure about configuration.

MrLightningBlaze · Answer 9 · 2019-09-19T12:48:06.000Z

I have noticed 0 drop in FPS or increase in CPU or RAM usage in the nether beyond what is expected (due to the amount of lava lighting in the nether), all with default Dynamic Surroundings config and essentially default CubicChunks config (A few modded dims in the blacklist), I can not speak for everyone, but I have not noticed preformance issues with it

Share to