CubicChunks

CubicChunks

Mods
840k Downloads

CubeWatchEvent not always fired

Johni0702 opened this issue ยท 1 comments

commented

Looking at CubeWatcher internals, I came across these lines which appear to send the cube to the player while never firing the CubeWatchEvent (haven't actually tested it, just a suspicion):

CubicChunks/src/main/java/io/github/opencubicchunks/cubicchunks/core/server/CubeWatcher.java

Lines 120 to 124 in 5cef9e0

if (this.sentToPlayers) {
this.sendToPlayer(player);
((CubicEntityTracker) playerCubeMap.getWorldServer().getEntityTracker())
.sendLeashedEntitiesInCube(player, this.getCube());
}

In contrast (when the cube is first loaded):

CubicChunks/src/main/java/io/github/opencubicchunks/cubicchunks/core/server/CubeWatcher.java

Lines 219 to 222 in 5cef9e0

for (EntityPlayerMP playerEntry : this.players) {
MinecraftForge.EVENT_BUS.post(new CubeWatchEvent(cube, cubePos, this, playerEntry));
sendToPlayer(playerEntry);
}

commented

That should be easy to fix.