CubicChunks

CubicChunks

840k Downloads

Breaking the Immersive Intelligence multi-block structure causes the client to close

sddsd2332 opened this issue ยท 6 comments

commented

My English is not very good, so this is translated by Google.

Version Information

Minecraft version: 1.12.2

Forge version: 14.23.5.2855

Other mods (if applicable):
CubicChunks-1.12.2-0.0.1233.0-SNAPSHOT-all.jar
CubicWorldGen-1.12.2-0.0.167.0-SNAPSHOT-all.jar
ImmersiveEngineering-0.12-98.jar
immersiveintelligence-0.2.1.jar

Steps to reproduce:

  1. Building a Immersive Intelligence Multiblock Coagulator
  2. Break the Multiblock Coagulator
  3. Client crashes directly, no crash record

Expected Behavior:
Destroys multiblock structures normally

Actual Behavior:
Client crashes directly, no crash record

Catching java.lang.ArrayIndexOutOfBoundsException: 0

Link to crash log (if applicable - use a site such as hastebin:

debug.log
latest.log

commented

also net.minecraft.advancements.AdvancementManager seems to keep going over all default block and items in game and giving the same error (Unknown recipe) and it all links back to ftb lib

commented

try removing optifine

commented

There are so many errors in this log that it might as well be impossible to draw any conclusions

Also immersive engineering doesn't support 1.12 anymore

commented

also net.minecraft.advancements.AdvancementManager seems to keep going over all default block and items in game and giving the same error (Unknown recipe) and it all links back to ftb lib

This is caused by pyrotech removing the crafting recipe

try removing optifine

After removing pyrotech and OptiFine_1.12.2_HD_U_G5
Re-destroy the Multiblock Coagulator
Crash again, still no crash report
debug-UltimateTechnology.log
latest-UltimateTechnology.log

For comparison
I only keep these mods
CubicChunks-1.12.2-0.0.1233.0-SNAPSHOT-all.jar
CubicWorldGen-1.12.2-0.0.167.0-SNAPSHOT-all.jar
ImmersiveEngineering-0.12-98.jar
immersiveintelligence-0.2.1.jar
immersivepetroleum-1.12.2-1.1.10.jar
jei_1.12.2-4.16.1.302.jar
journeymap-1.12.2-5.7.1.jar
JustEnoughCharacters-1.12.0-3.5.1.jar

Rebuild Immersive Intelligence Multiblock Coagulator
Break the Multiblock Coagulator
Client crashes directly, no crash record
debug - Compared.log
latest - Compared.log

commented

In debug, they point to respectively

https://github.com/BluSunrize/ImmersiveEngineering/blob/e7563329ddc61589ba552c17fc86e2a6e36fb408/src/main/java/blusunrize/immersiveengineering/common/blocks/TileEntityMultiblockPart.java#L284

https://github.com/Pabilo8/ImmersiveIntelligence/blob/fb18ad30d300af0306a2a98363eca29a25e3c513/src/main/java/pl/pabilo8/immersiveintelligence/common/blocks/multiblocks/metal/tileentities/second/TileEntityCoagulator.java#L197

https://github.com/BluSunrize/ImmersiveEngineering/blob/e7563329ddc61589ba552c17fc86e2a6e36fb408/src/main/java/blusunrize/immersiveengineering/common/blocks/TileEntityIEBase.java#L39

It looks like readCustomNBT caused the error

And the same is a multi-block structure Chemical Bath
then the destruction will not crash

https://github.com/Pabilo8/ImmersiveIntelligence/blob/fb18ad30d300af0306a2a98363eca29a25e3c513/src/main/java/pl/pabilo8/immersiveintelligence/common/blocks/multiblocks/metal/tileentities/first/TileEntityChemicalBath.java#L111

After comparing the two files
I think it should be caused by adding if(isDummy()) return; in readCustomNBT and writeCustomNBT

Maybe an Immersive Intelligence developer error?

removing CubicChunks and CubicWorldGen
Immersive Intelligence's multi-block structure breaks normally

message.getTileEntityTags().forEach(tags -> tags.forEach(tag -> {

I'm not sure if it's caused by CubicChunks adding tileEntity.handleUpdateTag(tag)

commented

something barteks gone need to look at