OptiFabric

OptiFabric

9M Downloads

Mod compatibility: When using OptiFabric with OptiFine 1.19 HD U H8, enabling Debugify's fix for MC-112730 ("Beacon beam and structure block render twice per frame") will cause beacon beams to not render at all.

akemin-dayo opened this issue · 0 comments

commented

Mod compatibility: When using OptiFabric with OptiFine 1.19 HD U H8, enabling Debugify's fix for MC-112730 ("Beacon beam and structure block render twice per frame") will cause beacon beams to not render at all.

I have reproduced this issue with Minecraft 1.19 + OptiFine 1.19 HD U H8 + OptiFabric 1.13.8, as well as OptiFabric 1.13.5.

Minecraft 1.18.2 + OptiFine 1.18.2 HD U H7 + OptiFabric 1.13.8 is NOT affected by this issue.

(※ Debugify is not available for older Minecraft versions, so 1.18.2 is the only relevant version here.)

The relevant source code for Debugify's MC-112730 fix can be found here — hopefully this is helpful to you.

https://github.com/isXander/Debugify/blob/1.19/fabric/src/main/java/dev/isxander/debugify/fabric/mixins/basic/client/mc112730/ChunkBuilderBuiltChunkRebuildTaskMixin.java

This code in question has not changed since it was initially written/committed, so the cause of this issue appears to be on OptiFabric's end.

Please do also let me know if you are considering this issue to be a wontfix. If so, I will open a PR for Debugify that will add modConflicts = "optifabric" to MC-112730's @BugFix annotation so that it will be automatically disabled when OptiFabric is present.

For reference, I've implemented this workaround in my own fork of Debugify, as seen below:

https://github.com/akemin-dayo/Debugify/blob/1.19/src/client/java/dev/isxander/debugify/client/mixins/basic/mc112730/ChunkBuilderBuiltChunkRebuildTaskMixin.java#L13