OptiFabric

OptiFabric

9M Downloads

7d01086833 breaks 1.18.2 + Fabric API 0.75.1

XXMA16 opened this issue ยท 1 comments

commented

The game crashes as soon as you load into a world, be it single or multi player. As far as I tested this seems to be caused by the trailingBoolean stuff added to ChunkRendererFix, as removing this particular change does not cause any issue in <1.19.3 (however it does break 1.19.3 in the same manner described).

These are the important bits of the stacktrace:

java.lang.RuntimeException: Mixin transformation of net.minecraft.class_846$class_851$class_4578 failed
Caused by: org.spongepowered.asm.mixin.injection.throwables.InjectionError: Critical injection failure: Redirector hookChunkBuildTesselate(Lnet/minecraft/class_776;Lnet/minecraft/class_2680;Lnet/minecraft/class_2338;Lnet/minecraft/class_1920;Lnet/minecraft/class_4587;Lnet/minecraft/class_4588;ZLjava/util/Random;)Z in fabric-renderer-indigo.mixins.json:MixinChunkRebuildTask from mod fabric-renderer-indigo failed injection check, (0/1) succeeded. Scanned 1 target(s). Using refmap fabric-renderer-indigo-refmap.json
java.lang.NullPointerException: Cannot invoke "net.minecraft.class_746.method_3146(String)" because "this.field_3690.field_1724" is null
java.lang.NullPointerException: Cannot invoke "net.minecraft.class_1657.method_31549()" because "$$1" is null
java.lang.NullPointerException: Cannot invoke "net.minecraft.class_746.method_31548()" because "this.field_3690.field_1724" is null
java.lang.NullPointerException: Cannot invoke "net.minecraft.class_1657.method_31549()" because "$$1" is null
java.lang.NullPointerException: Cannot invoke "net.minecraft.class_746.method_31548()" because "this.field_3690.field_1724" is null
java.lang.NullPointerException: Cannot invoke "net.minecraft.class_746.method_3130()" because "this.field_3690.field_1724" is null
java.lang.NullPointerException: Cannot invoke "net.minecraft.class_1657.method_18798()" because "$$1" is null
commented

I looked into it and it seems that the issue is caused by the fact that nativeRandom checks the last index which is a net/minecraftforge/client/model/data/IModelData instead of checking the second to last one.