Ore Tweaker

Ore Tweaker

8M Downloads

Conflict with zycraft's zychorium ore-gen

frank89722 opened this issue · 6 comments

commented

Forge version: 36.1.16
OreTweaker version: 2.0.1
ZYcraft: https://github.com/nikita488/ZYCraft

All configs are default

Before OreTweaker installed:
image

After:
image

commented

2021-05-13_08 58 55
I fixed it, found the issue.

There is a loop grabbing the ore from the ore gen feature, and I check if the block != null. If yes I remove that feature. But the block is never set back to null at the start / end of the loop and will therefore remove all the next entries.
I lost sleep over this simple little issue and took me days to debug..

I moved the Block targetBlock = null; inside the loop and now everything works fine.

commented

I consider this issue now fixed. Thank you for your bug report.
Patch can be found here: https://www.curseforge.com/minecraft/mc-mods/ore-tweaker/files/3307868

commented

Thanks, will look into it.

commented

It seems like only happened when replacing "minecraft:lapis_ore" in the json file, but this is only valid in only vanilla ores in the config.

I have tried to remove lapis ore in the setting for my large modpack with other moded ores in it, but it still not work.

Hope this information is helpful to you!

commented

Yes, had the same bug for Create. Still struggling how to fix it, but I can hard code a temporary workaround

commented

Maybe could move the adding event to high priority, and split the removing part to a low priority event? 🤔

Also, quark seems like having the same issue. If you decide to code a temporary workaround, it would be nice to having quark support.

All the best!