[Bug] Unregistered ConfiguredFeature messages
lynnpye opened this issue ยท 2 comments
Minecraft Version
1.16.5
Forge Version
36.2.0
Mod Version
1.16.5-2.3.1
Describe the bug
When Blame is also installed, during startup or when loading or creating a world, the following will be sent to latest.log:
****************** Blame Report Unregistered Worldgen 1.16.5-3.3.0-forge ******************
These ConfiguredFeature was found to be not registered. Look at the JSON info and try to
find which mod it belongs to. Then go tell that mod owner to register their ConfiguredFeature
as otherwise, it will break other mods or datapacks that registered their stuff.
Unregistered ConfiguredFeature JSON info : {
"config": {
"feature": {
"config": {
"feature": {
"config": {
"feature": {
"config": {
"target": {
"block": "minecraft:stone",
"predicate_type": "minecraft:block_match"
},
"state": {
"Name": "minecraft:gravel"
},
"size": 33
},
"type": "minecraft:ore"
},
"decorator": {
"config": {
"bottom_offset": 1,
"top_offset": 1,
"maximum": 256
},
"type": "minecraft:range"
}
},
"type": "minecraft:decorated"
},
"decorator": {
"config": {},
"type": "minecraft:square"
}
},
"type": "minecraft:decorated"
},
"decorator": {
"config": {
"count": 8
},
"type": "minecraft:count"
}
},
"type": "minecraft:decorated"
}
Biome affected : All biomes
[14:47:26] [Render thread/ERROR]:
----------------------------------------------------------------------------------
Unregistered ConfiguredFeature JSON info : {
"config": {
"feature": {
"config": {
"feature": {
"config": {
"feature": {
"config": {
"target": {
"block": "minecraft:netherrack",
"predicate_type": "minecraft:block_match"
},
"state": {
"Name": "minecraft:nether_gold_ore"
},
"size": 11
},
"type": "minecraft:ore"
},
"decorator": {
"config": {
"bottom_offset": 10,
"top_offset": 10,
"maximum": 118
},
"type": "minecraft:range"
}
},
"type": "minecraft:decorated"
},
"decorator": {
"config": {},
"type": "minecraft:square"
}
},
"type": "minecraft:decorated"
},
"decorator": {
"config": {
"count": 10
},
"type": "minecraft:count"
}
},
"type": "minecraft:decorated"
}
Biome affected : All biomes
[14:47:26] [Render thread/ERROR]:
----------------------------------------------------------------------------------
Unregistered ConfiguredFeature JSON info : {
"config": {
"feature": {
"config": {
"feature": {
"config": {
"feature": {
"config": {
"target": {
"block": "minecraft:netherrack",
"predicate_type": "minecraft:block_match"
},
"state": {
"Name": "minecraft:ancient_debris"
},
"size": 3
},
"type": "minecraft:ore"
},
"decorator": {
"config": {
"bottom_offset": 8,
"top_offset": 8,
"maximum": 120
},
"type": "minecraft:range"
}
},
"type": "minecraft:decorated"
},
"decorator": {
"config": {},
"type": "minecraft:square"
}
},
"type": "minecraft:decorated"
},
"decorator": {
"config": {
"count": 1
},
"type": "minecraft:count"
}
},
"type": "minecraft:decorated"
}
Biome affected : All biomes
[14:47:26] [Render thread/ERROR]:
----------------------------------------------------------------------------------
Unregistered ConfiguredFeature JSON info : {
"config": {
"feature": {
"config": {
"feature": {
"config": {
"feature": {
"config": {
"target": {
"block": "minecraft:netherrack",
"predicate_type": "minecraft:block_match"
},
"state": {
"Name": "minecraft:nether_quartz_ore"
},
"size": 15
},
"type": "minecraft:ore"
},
"decorator": {
"config": {
"bottom_offset": 10,
"top_offset": 10,
"maximum": 246
},
"type": "minecraft:range"
}
},
"type": "minecraft:decorated"
},
"decorator": {
"config": {},
"type": "minecraft:square"
}
},
"type": "minecraft:decorated"
},
"decorator": {
"config": {
"count": 10
},
"type": "minecraft:count"
}
},
"type": "minecraft:decorated"
}
Biome affected : All biomes
How to reproduce
Setup new instance with the indicated Forge/MC versions, plus Blame mod and Ore Tweaker of the specified version. In the configs folder, pre-create the oretweaker subfolder and place a copy of default.json there named OreTweaker.json. Launch to the title screen and the output should appear.
I submitted a pull request with a possible fix. Basically, rather than just use the ore name as the feature registration key, I glom the ore, the filler, the min, max heights, and spawn rate into a hopefully unique key. Local testing showed it addressed the issue, but obviously you'd have more experience in figuring out if this is an appropriate fix. :)