1.19 release
keleko34 opened this issue · 10 comments
What would it take to update this to 1.19? is it a great undertaking/amount of work?
so far the only big change I saw was TextComponent was removed and replaced with Component.literal, also mixin 7 is no longer in snapshot
Shouldn't be too hard, but I still have bugs to fix in 1.18.2 and forge 1.19 hasn't had a RB yet, which means code may change and hooks crash. If you want to try it yourself, here is the build repository, which includes references to all three mods.
I know mojang basically changed nothing between 1.18.2 and 1.19. All major changes for 1.19 where contained the 1.18.1->1.18.2 release, and it's not the issue. Origins (Apoli more specifically) way to much mixins to have an unstable codebase, and looking at forge 1.19's changelog, there seem to be a lot of patch changes this time.
Plus they finally implemented a Jar-in-Jar system, which means I can finally stop merging all 4 mods in one, but at the cost of trying to understand a poorly documented system.
Right, so I got into the 1.19 port, and it's going to take some time. The largest change is the removal of IForgeRegistryEntry, which I was relying on for most of my code. That means I'm moving everything to the vanilla system (i.e. Holder or RegistryEntry for yarn users) which is:
- A breaking change
- A decent amount of work since that means rewriting apoli's PowerContainer and origins' OriginContainer.
TL;DR: Expect some amount of time before 1.19 release.
Right, so I got into the 1.19 port, and it's going to take some time. The largest change is the removal of
IForgeRegistryEntry, which I was relying on for most of my code. That means I'm moving everything to the vanilla system (i.e.HolderorRegistryEntryfor yarn users) which is:
- A breaking change
- A decent amount of work since that means rewriting apoli's PowerContainer and origins' OriginContainer.
TL;DR: Expect some amount of time before 1.19 release.
Dang, ok. I would help but it may take me awhile to figure out the origins codebase.
Test build 1 in pre-releases. Haven't even booted the game to test it but hey, there's technically a 1.19 version now :P.
I'll fix errors that will inevitably occur later.
Right, so I got into the 1.19 port, and it's going to take some time. The largest change is the removal of
IForgeRegistryEntry, which I was relying on for most of my code. That means I'm moving everything to the vanilla system (i.e.HolderorRegistryEntryfor yarn users) which is:
- A breaking change
- A decent amount of work since that means rewriting apoli's PowerContainer and origins' OriginContainer.
TL;DR: Expect some amount of time before 1.19 release.
About how long?
You can find test build 3 in the github releases page. As stated in the first message, test build for now since forge managed to produce a lot of breaking changes in the past few days, so for now it requires Forge 41.0.63.