Origins (Fabric)

Origins (Fabric)

15M Downloads

Mod conflict with Dawn API

K0-RR opened this issue ยท 4 comments

commented

MC crashes (but the game is still logging) when loading Origins and Dawn API mod.

Reported to DawnTeamMC too - DawnTeamMC/DawnAPI#2

crash report - https://hatebin.com/qnmeozqeaw
latest.log - https://hatebin.com/flwzviqyah - warning very long file

commented

@apace100 how could we work this out? If you want, I could add some kind of method to my API to allow some kind of compatibility.

Affected mixins:

commented

This is interesting. I thought it would be difficult at first and we'd need some additional library mod, but it seems the incompatibility really isn't necessary - you are targetting the blindness check, while I'm targetting the night vision check. I've added an ordinal = 1 to my Mixin target to only target the night vision check. I sent you a PR which changes your mixin to only target the Blindness check: I've tested the two changed builds in a clean environment, and the mods are compatible with these changes. The functionality of both mods should not be affected.

Edit: link to the PR: DawnTeamMC/DawnAPI#4

commented

Oh wow, this is really super odd... and also interesting. Thanks for explaining it to me, and thanks a lot for the PR!

commented

With Origins 0.4.3 and Dawn API 1.5.3, this issue is fixed. :)