Origins (Fabric)

Origins (Fabric)

17M Downloads

origins:empty cause GodMode

imxzrui opened this issue · 4 comments

commented

i run a origin server with Minecraft1.20.1+Fabric0.16.10+FabricAPI0.92.5,the version of origin is 1.10.0
In theory, origins: empty will not exist within the game,I thought the same way at first.But,by chance,I found that a player is completely invincible.
I couldn't figure it out after much thought, but after investigation, I finally confirmed that the problem lies in the Origins MOD.
Due to some unknown errors, the player's origins have been set to 'origins': empty, And without using administrator instructions or modifying code.
It is also this emptiness that makes the player almost GodMode, where only commands can kill him.
origins:empty should not appear in games, so it doesn't really matter how its properties are set. But the fact is, it naturally appeared and caused GodMode.
You can fix the relevant vulnerabilities to make origin: empty truly impossible to occur. Alternatively, more safely, I would recommend that you modify the code for origins: empty to make it look like the original player or human, rather than GodMode.

commented

After further testing, the same issue also occurred in your affiliated origin classes
Setting origins-classes:class to origins:empty will also result in GodMode, and this does not require both origins and origins to be set to empty at the same time. Only if either one is set, then GodMode will occur

commented

This is a known issue and has been fixed in newer versions of Origins (starting from Origins 1.11.0) by changing how the "origin selection invulnerability" feature works (it now only makes the player invulnerable when actively selecting an origin instead of having the origins:empty origin in any origin layer.)

There isn't really a one-way-fix for this in older versions (at least on the user's side) and I don't really have the time to backport the fix

commented

This is a known issue and has been fixed in newer versions of Origins (starting from Origins 1.11.0) by changing how the "origin selection invulnerability" feature works (it now only makes the player invulnerable when actively selecting an origin instead of having the origins:empty origin in any origin layer.)这是一个已知问题,在起源的新版本(从 1.11.0 开始)中已修复,通过改变“起源选择无敌”功能的工作方式(现在仅在玩家主动选择起源时使其无敌,而非在任何起源层拥有 origins:empty 起源时)。

There isn't really a one-way-fix for this in older versions (at least on the user's side) and I don't really have the time to backport the fix对于旧版本来说,确实没有一个单向修复方案(至少在用户端),而且我也没有时间将修复反向移植到旧版本。

can you just add a config for origins:empty to origins_server.json?Allow us to configure whether empty is given an invincible state.This is a good and simple temporary solution.

commented

I don't think that's necessary considering that origins:empty is a special origin specifically used as a placeholder for when there is no origin in an origin layer. 🤔

Even then, as mentioned earlier, I don't really have the time to do that or backport the already implemented fix from newer versions to older versions. I'm keeping this issue open though