Oritech

Oritech

588k Downloads

Server crashes when players login

SugarMGP opened this issue ยท 5 comments

commented

Issue description

Server crashes for a short period of time after a player enters the server

Steps to reproduce

No response

Minecraft version

1.21.1 (Latest)

Platform

Fabric

Loader version

0.16.10

Fabric API version

0.115.1+1.21.1

Oritech version

0.14.3

Other relevant versions

No response

If a (crash)log is relevant for this issue, link it here: (It's almost always relevant)

https://pastebin.com/RtRzZ3HD

commented

A bit more information would be appreciated. There's a field called "Steps to reproduce" in the issue template, which would've been helpful here.
Based on the logs it seems like a multiblock machine is having a pipe block located at its core but is assembled, which I don't see how this could ever happen. Do you know what you / the players did to cause the crash?

commented

I made some temporary changes to prevent crashes and logging errors, then realized it was an energy pipe that was causing the error (at the position indicated by the crosshair).

6d03c7dbeab0dc0d08875bdbf4d2fc4d.png

But strangely, even though I've removed the pipes and nearby blocks, the location is still reporting an error.

345002f8ff03c6174bca15f972691e8c.png

Let me know if you need more information.

commented

A bit more information would be appreciated. There's a field called "Steps to reproduce" in the issue template, which would've been helpful here. Based on the logs it seems like a multiblock machine is having a pipe block located at its core but is assembled, which I don't see how this could ever happen. Do you know what you / the players did to cause the crash?

If you can't solve the problem for now, can you temporarily fix the code in the next release to avoid crashes? This would be very helpful to me.

commented

I have same issue, I've compiled the fork and I found approximate of where the problem is and I noticed that one energy pipe was not connecting to other pipe, however after destroying it I was still getting error but then i noticed i had two invisible machine cores, after destroying one of them the erroring stopped. Unfortunately I've already fixed it so I don't have the save.
I will try to reproduce this.

commented

I was able to reproduce, happens in both 0.14.3 and 0.14.4 version. In my case I'm using lava generator as example but might happen with other. I've also checked are any other mods are at issue but if i just install oritech with dependencies this also happens.

The main reason this happens is when a multiblock machine gets destroyed not directly by user but by tnt/creeper/similar it destroys the lava generator block but not the machine core which I'm guessing leaves the multiblock marked as "functional" while it no longer functions.

This however is not the whole reason why it crash, for me it crashes when I place a energy cable in place of lava generator block, also said lava generator needs to hold power in it, if its empty it doesn't crash.

I'm attaching a video showing this error. I've checked logs and looks mostly same as SugarMGP's crash report, the "headline" of crash is same but then stacktrace is different (idk much java sorry) crash report for this video. This happens both in singleplayer and multiplayer, the video is from server however with same steps I was able to reproduce this in singleplayer.

oritech.multiblock.bug-2.mp4

I'm not however able to reproduce the way it happened to me originally, I know that at some point next to my lava generators a creeper exploded but then I didn't really pay much attention to it and didn't notice the invisible machine cores (its kinda hard to see them xd). Some time after the creeper exploded i left the server and before next session I updated my mods (probably unrelated) and when tried to join the server it would crash. Maybe I had some kind of desync with the server and when it loaded the save back it happened.