[FABRIC] Outvoted

[FABRIC] Outvoted

583 Downloads

Rendering errors due to biome variants

Warbringer12 opened this issue ยท 22 comments

commented
  1. loaded into world

If applicable, add screenshots to help explain your problem, or logs from Pastebin or similar.
crash-2020-11-22_18.44.14-client.txt
debug.log
latest.log

Version (please complete the following information):

  • Minecraft Version 1.16.4
  • Mod Version b0.4.1
commented

Judging by the log it looks like you're running Java 14, which can cause issues with Minecraft.
Are you able to try running Java 8 instead and try to see if the issues still stands?

commented

Can confirm it happens in java 8 too,

Java 1.8.0_271
Forge 35.1.2
Outvoted b0.4.1

crash-2020-11-22_22.52.21-client.txt

commented

Interesting. Could both of you @Warbringer12 and @Keb911 try the jar in the attached zip file and report back if the issue still occurs? Thanks!
outvoted-1.16.3-b0.4.1-a.jar.zip

commented

The issue no longer occurs with that version, thanks.

commented

Great! I'll be pushing out an official update soon.

commented

I downloaded the file you sent but I keep getting the same error. I'm running on 1.16.3 so I don't know if that can be an issue

commented

I downloaded the file you sent but I keep getting the same error. I'm running on 1.16.3 so I don't know if that can be an issue

@Charwten
Oh, really? Are you getting the same error in the log or is it separate? So far everyone else has had success with it and I'm unable to replicate the issue on my end before + after fix for some odd reason.

commented

I downloaded the file you sent but I keep getting the same error. I'm running on 1.16.3 so I don't know if that can be an issue

@Charwten
Oh, really? Are you getting the same error in the log or is it separate? So far everyone else has had success with it and I'm unable to replicate the issue on my end before + after fix for some odd reason.

Yeahh I just get the same error of this.
crash-2020-11-24_11.12.06-client.txt

commented

Interesting...
I have already stated that I've never been able to replicate the issue in the first place and just went out on a whim on a line of code that'd fix the problem. I'll do some further testing to see if I can replicate it.

commented

Alright. Sorry to bother you if this is just out of the blue for you but thank you nonetheless for the help :)

commented

No worries, it's fine. The last thing I want is game breaking bugs.

commented

I thought of something. Are @Warbringer12 and @Charwten on a server? I experienced the original issue on a friend's server, but only tested b0.4.1a on a single player world. I wonder if this only happens on a server?

commented

@Keb911 Yeah! I play with some friends on a server and I had the same exact thing! I tried the b0.4.1a file on single player and it worked but didn't on multiplayer

commented

Ok that helps. So I assume they don't use the hotfixed jar on the server. I assumed since the crash was related just to the rendering it would only be a client-side fix but it seems to be more than that. I still can't reproduce the crash on my end and I'm unsure as to why, must be something with my dev environment.
Sorry for bugging ya but is one of you able to see if using the hotfixed jar on the server fixes the problem?

commented

I'll be honest.. I do not know what you mean by hotfixed jar lmao! What do you mean?

commented

The jar in the zip from earlier with the crashing fix, that you used in singleplayer.

commented

Oh yeah! Sorry about that! I tried it on the server and I had the same problem with the crash

commented

Ok it seems the method I use to check biomes for the texture variants just... doesn't work on a server? I don't know of any fixes as I've meddled with it for about a day and I think it might just be beyond my knowledge. I'll probably just subtract the Kraken variants for now, which isn't ideal at all but it's the quickest fix so the next release isn't too delayed.

commented

getting the same issue with Inferno Entity. Will attempt to turn off variants to see if CTD stops on the server.

Disabling the variants worked. You may want to default them to false until theres a solution and comment that they will CTD a client connected to a server.

commented

getting the same issue with Inferno Entity. Will attempt to turn off variants to see if CTD stops on the server.

Disabling the variants worked. You may want to default them to false until theres a solution and comment that they will CTD a client connected to a server.

Thank you for this! Looks like I might have to incorporate a different method for biome variants. I suspect it could be related to how the Inferno and Kraken variants are configurable, while the Hunger's is hardcoded, as I haven't had any crash reports related to Hunger rendering despite it having texture variants.

commented

heres a crashlog in case it sheds some light
https://pastebin.com/0fRrSwhY
and the CTD error is AL lib: (EE) alc_cleanup: 1 device not closed

commented

Sort of fixed in 32c7e7b. With the way I now do biome variants to prevent server crashes, that is checking the block it spawns on instead of the biome, the Kraken's variants won't work since it spawns in water but Inferno and Hunger will work with this method. For now, Kraken variants will still be disabled until I can find a better method. I'll close this issue for now, but that does not mean I won't keep trying to find a compatible method.