Add trinkets/curios support
Rakambda opened this issue · 15 comments
Add trinkets/curios support.
Discussed in #103
Originally posted by Vixeliz September 1, 2022
Describe the feature
This may already be done but I couldn't find any info confirming it. I am using ElytraSlots with Trinkets. And I was wondering does this mod also take account items equipped in trinket slots? I think it would be a nice addition if it doesn't.
@Vixeliz From what I understood, you seem to use the Forge side of the force.
I made some changes with (hopefully) support for Curios inventories.
If you can try it that'd be cool.
You'll find the mod inside a zip file in the artifacts section : https://github.com/RakSrinaNa/OverpoweredMending/actions/runs/2974773754
I actually do use fabric I can set up a forge instance if you would like me to try out the forge version. But I do indeed use fabric with trinkets.
So the forge version does appear to crash when collecting experience orbs so you are aware. This is just a minimal forge instance on latest recommended forge version and latest versions of curios, caelus, elytraslot, and overpowered mending from the github action. I uploaded the log if you would like to look at it.
No worries I'll do trinkets
Awesome I still am setting up a minimal forge instance just to let you know if the curios implementation works.
That's what happens when not testing on my side 😆
Should be fixed there: https://github.com/RakSrinaNa/OverpoweredMending/actions/runs/2974868977
For trinkets though maybe it'll be done over the weekend. My fabric/forge setup decided to give random IO errors 😞
No worries! Thanks for working on it at all! I'll test in a minute to make sure curios works. Whenever you do get around to adding trinkets just ping me and i'll be happy to test.
@Vixeliz There should be Trinkets support (hopefully, I didn't test 😆 ) in this build: https://github.com/RakSrinaNa/OverpoweredMending/actions/runs/2980910440
I will add it to my modpack and see if any problems arise with more mods(i tested in a minimal environment) I'll update you if I find any issues in the larger modpack.
👍 Will release it officially maybe at the end of the weekend. I don't know if you play to play with it until then but who know, maybe a bug can pop up during that time.
Thanks for testing !
